From 6b58d82e075cc3a592bf2e1ea242467b53218de8 Mon Sep 17 00:00:00 2001 From: "anthony.bellino" Date: Tue, 7 Aug 2018 17:20:53 +0000 Subject: [PATCH] armada Remove duplicate validation calls during an armada apply This PS removes dead code in pre_flight_ops() since validation already occurs on L130. Change-Id: Ie2f822009f1e56cdfc1273a9b308efafdb855f13 --- armada/handlers/armada.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/armada/handlers/armada.py b/armada/handlers/armada.py index 1c019916..2c8b1911 100644 --- a/armada/handlers/armada.py +++ b/armada/handlers/armada.py @@ -139,13 +139,6 @@ class Armada(object): raise validate_exceptions.InvalidManifestException( error_messages=details) - # TODO(MarshM): this is duplicated inside validate_armada_documents() - # L126, and should be unreachable code if it has errors - result, msg_list = validate.validate_armada_manifests(self.documents) - if not result: - raise validate_exceptions.InvalidArmadaObjectException( - details=','.join([m.get('message') for m in msg_list])) - # Clone the chart sources repos = {} manifest_data = self.manifest.get(const.KEYWORD_ARMADA, {})