airship
/
tempest-plugin
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review+1

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 29624 <29624@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
This commit is contained in:
Gerrit User 29624 2019-05-08 12:58:38 +00:00 committed by Gerrit Code Review
parent c3964f2cf6
commit 3d88901784
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
ce79550ee1fa12ea0d677b13a94c737c706f8541
View File

@ -39,6 +39,29 @@
"revId": "ce79550ee1fa12ea0d677b13a94c737c706f8541",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_48ae0999",
"filename": "tox.ini",
"patchSetId": 4
},
"lineNbr": 3,
"author": {
"id": 29624
},
"writtenOn": "2019-05-08T12:58:38Z",
"side": 1,
"message": "suggest in a separate patch removing py27, and adding py37 as a check - but not a gate - to see if we are currently py37 compatible. if so, we can consider adding the gate as well to keep code future compatible.",
"range": {
"startLine": 3,
"startChar": 20,
"endLine": 3,
"endChar": 24
},
"revId": "ce79550ee1fa12ea0d677b13a94c737c706f8541",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}