diff options
authorJames E. Blair <>2017-01-12 09:55:37 -0800
committerJames E. Blair <>2017-01-12 09:55:37 -0800
commit8d0f0bfd0a7288b4bdc2782ed2d1dcf626e8a3ba (patch)
parent3fe078c070f29bb12e8d8228cc18b9b163d11805 (diff)
Set facts type to dict
With newer versions of ansible, module arguments are assumed to be strings unless otherwise specified. Our 'facts' argument is expected to be a dictionary, so tell ansible that. Without this, the argument will arrive as a string and be written to the facter file inside string quotes. Facter will produce the following error: undefined method `each' for #<String:0x000000016ee640> Change-Id: Iea626466d0920349f434f678fe2f71cbee259383
Notes (review): Code-Review+2: Clark Boylan <> Code-Review+2: Paul Belanger <> Workflow+1: Paul Belanger <> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 12 Jan 2017 18:11:11 +0000 Reviewed-on: Project: openstack-infra/ansible-role-puppet Branch: refs/heads/master
1 files changed, 1 insertions, 1 deletions
diff --git a/library/puppet b/library/puppet
index b45716d..2972448 100644
--- a/library/puppet
+++ b/library/puppet
@@ -163,7 +163,7 @@ def main():
163 show_diff=dict( 163 show_diff=dict(
164 # internal code to work with --diff, do not use 164 # internal code to work with --diff, do not use
165 default=False, aliases=['show-diff'], type='bool'), 165 default=False, aliases=['show-diff'], type='bool'),
166 facts=dict(default=None), 166 facts=dict(default=None, type='dict'),
167 facter_basename=dict(default='ansible'), 167 facter_basename=dict(default='ansible'),
168 environment=dict(required=False, default=None), 168 environment=dict(required=False, default=None),
169 certname=dict(required=False, default=None), 169 certname=dict(required=False, default=None),