opendev
/
elastic-recheck
Code Issues Proposed changes

provide a more targetted location setting 

The previous fix to make #target work correctly failed in an infinite
loop on the null case where no hash was set. Trying a more targeted
approach.

Change-Id: I7deaee9b8a3a3ba815640c7cb2faea84032387bb
This commit is contained in:
Sean Dague 2015-04-29 12:35:54 -04:00
parent 90110a0215
commit 791052ddee
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
web/share/elastic-recheck.js
View File

@ -42,6 +42,13 @@ function update_graph_for_bug(main, bug) {
div.css('height', 'auto');
div.parent().css('opacity', '0.5');
}
// if we've updated the bug number in question, and our requested
// location is this bug, reset the window location to visually
// scroll us to this point.
if ( ("#" + bug) == window.location.hash ) {
window.location.replace(window.location.href);
}
}
function update_critical_dates(data) {
@ -93,11 +100,6 @@ function update() {
update_graph_for_bug(main, bug);
}, 1);
});
// we have anchor tags, however on first load the relevant
// sections don't exist, so after we load graph points, change
// our anchor as well.
window.location.replace(window.location.href);
});
};