By default we add 'voting:1' to all queries so they are filtered
from the graph.
There are cases where we want to track bugs for non-voting jobs
in the graph, so add an 'allow-nonvoting' key for special bugs
that we want to track while we're trying to stabilize a job.
Updates the docs, adds a test query and unit test for the query
loader, fixes a bad query that was setting voting:1 already, and
removes the TODO in the query for bug 1539271.
Change-Id: I61b1d4b0faaa3f20fc5b04aa3392c68c61990866
Elastic recheck is about failures, all queries should only include
voting changes. We do this by explicitly adding voting:1 to all
queries that load in the query builder.
Change-Id: I4bd4827f72d85bf69bf501be2f5744e71de35a3c
This reverts commit e75b996e60.
Change is being reverted because we can't actually use a static LOG
object if we expect setup_logging to do the right thing at runtime.
Python logging will load logging objects at import time using the static
LOG object before setup_logging can run otherwise.
Conflicts:
elastic_recheck/bot.py
elastic_recheck/elasticRecheck.py
Change-Id: I582c7e9c9b3c2ccab6a695bfba00a61f7c0a04a9
this whole theory of keeping old queries around was a better
theory than practice, especially given that we currently have nearly
60 open queries. We also change files and formats often enough that
the old queries really don't bring any value to the table.
remove support for soft delete on queries to prevent this debt from
building up further.
Change-Id: I3f09358133463d1650cc755cd6a39964f79c7fc8
As we continue to use elastic-recheck the number of skipped bugs will
continue to grow, and we reload bugs every time we attempt to classify a
bug so the logs get spammed with fairly useless comments about skipping
bugs.
Change-Id: I35bda3326379a77d1048f11cfd80ba8af8d05eaa
Add a resolved_at attribute in the query yaml files
that can be used to mark when a bug has been
fixed or does not occur any more. This can help us
re-enable bugs quickly when we see them again.
Change-Id: I7af7ce9417eec5ff9ecc2487a920ff9d1286a714
this handles the piece of work we've been talking about for a while
in moving the queries.yaml file into a directory with a bunch of
files. These remain yaml so that they can be tagged with additional
metadata. This would support the concept of soft deleting as well
as other useful meta data to gauge our evolution of the bugs we
track over time.
This should see some real review as it's extensive enough of a
change that the existing tests might not be sufficient. However it
should be enough to move this forward quite a bit.
This also makes future looking statements about doing soft deletes
with a resolved_at keyword in the future. That implementation will
come later.
Change-Id: I86317fcf6f1886ab5b6c0ee154b29e71865c52b7
Matt Riedemann