* stable:
Fix ChangeDetailFactory's invocation of PatchSetDetailFactory
Release notes for 2.1.7.1
Fix API breakage on ChangeDetailService
Do not reset Patch History selection on navigation to next file diff
Resolve Project Owners when checking access right on any ref
Conflicts:
gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java
gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java
Change-Id: I6e956625cb4648df35035b9be2d32e6e431fb8f3
I flipped the order of the arguments, but did not correctly
update all callers.
Change-Id: Iae14ec35374342f53bc353082db35cb8750a750a
Signed-off-by: Shawn O. Pearce <sop@google.com>
Version 2.3.0 contains at least one bad thread locking bug where
locks are grabbed but not released in the LDAP cache, resulting in
the server eventually being unable to service any requests without
a JVM restart.
Move back to 1.7.2, a version that we have proven to be stable in
production servers.
Change-Id: I2db36dbb7a3b74435d20de64c3dbb687d4f1c580
Signed-off-by: Shawn O. Pearce <sop@google.com>
This reverts commit e7db8b6de0.
The 7.4.0 release seems to have issues with SSL certificates. We are
getting millions of log entries like:
...
3166773 [2011-05-09 14:22:52,556] WARN org.eclipse.jetty.util.log : javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
3166774 [2011-05-09 14:22:52,556] WARN org.eclipse.jetty.util.log : javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
3166775 [2011-05-09 14:22:52,556] WARN org.eclipse.jetty.util.log : javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
3166776 [2011-05-09 14:22:52,556] WARN org.eclipse.jetty.util.log : javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
3166777 [2011-05-09 14:22:52,556] WARN org.eclipse.jetty.util.log : javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
...
Revert the upgrade until upstream is can fix the issue.
Conflicts:
pom.xml
Change-Id: I75f58d0cf99555ae5ead75fae232b75553076a79
This simple command looks at every change's most recent patch set
and reindexes the associated tracking information, based on the
current trackingid blocks in gerrit.config. Administrators can
run this command to reindex existing records after making changes.
Bug: issue 124
Change-Id: I152ce430f84b70b6f84510f1abefc8da6037e746
Signed-off-by: Shawn O. Pearce <sop@google.com>
The final releas version of 0.8.4 only contains a handful of Eclipse
specific license document related fixes that have no impact on us.
Picking up the final release version may give people a bit more of
a warm-and-fuzzy feeling about Gerrit.
Change-Id: I19beef56969ba439d34c401818f4f5b6deb70234
Signed-off-by: Shawn O. Pearce <sop@google.com>
I swapped review for approve.
Change-Id: I95ee994d0b65a6b92da74643ef124a19f93efbb0
Noticed-by: Ishaaq Chandy
Signed-off-by: Shawn O. Pearce <sop@google.com>
A bug in JGit's footer match method caused "Sample-Bug-Id: 42"
to be treated identical to the footer line "Signed-off-by: 42".
Since Signed-off-by tags are converted into reviewers, we were adding
account number 42 as a reviewer anytime we saw "Sample-Bug-Id: 42".
This happened for any footer line key, so long as its length matched
the length of "Signed-off-by".
This was fixed in a newer version of JGit, so upgrade.
Also prevent "Signed-off-by: 42" from being treated as an account.
Within a commit message, we only want to match to a reviewer by
their full name or their email address. Matching on their internal
database id number isn't useful.
Bug: issue 553
Change-Id: Ie26974240f26d29fb55cd95dc6b6c72c89903f37
Signed-off-by: Shawn O. Pearce <sop@google.com>
If the user name is set in Gerrit, but is no longer configured
in LDAP, allow it to be cleared by passing in a null name to the
ChangeUserName action.
Change-Id: Ie52fdf5b899e61456ea268aef93795ca00eed213
Signed-off-by: Shawn O. Pearce <sop@google.com>
This way older versions of the documentation are properly archived
in SVN as their own subdirectories, making it easier to examine any
prior build's documentation when necessary.
Change-Id: I15afe13adbe185c8b6ba6fb2002dd67ff04d44e1
Signed-off-by: Shawn O. Pearce <sop@google.com>
The patch releases have traditionally used the same release notes
file as their parent release, so just point to them directly on
the same line in the index.
Change-Id: Ifcdeeebb12bb129d610085165a61ffff7024bf51
Signed-off-by: Shawn O. Pearce <sop@google.com>
This way we can keep track of the release notes on a per-release
basis easier, by writing the notes directly as text files.
Change-Id: I0777120da45793ccb83aa5a580a59fbf99d06480
Signed-off-by: Shawn O. Pearce <sop@google.com>
Ian Wienand