Replace the link to the settings/agreements page in the git push error
message with a hardcoded link to the OpenStack wiki.
Remove the form widgets that permit agreeing to a CLA.
Change-Id: Ibfbb8bec245ae494a49cb905925fd2c4f34686f2
Add a test in receive commits for commit message first lines of over 50
characters and a boolean config option to enable checking for it.
Change-Id: I557d1ff72e6df97b991b05c36483c13873b706fb
* stable:
Fix ChangeDetailFactory's invocation of PatchSetDetailFactory
Release notes for 2.1.7.1
Fix API breakage on ChangeDetailService
Do not reset Patch History selection on navigation to next file diff
Resolve Project Owners when checking access right on any ref
Conflicts:
gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java
gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java
Change-Id: I6e956625cb4648df35035b9be2d32e6e431fb8f3
The Mylyn Reviews project pointed out Gerrit changed the API
signature of a JSON method they use remotely. Fix the API back to the
original signature, and define a new method with the extra arguments.
Change-Id: I51cbbdd64bdb72a666a6b5266db3b93494b75182
Signed-off-by: Shawn O. Pearce <sop@google.com>
When the user views a file diff and then changes in the Patch History
the selection of side A (left side), then this selection is lost when
the user navigates to the previous or next file diff. The selection of
side A is always reset to the patch set that is selected as 'Old
Version History' on the ChangeScreen (the base for comparing patch
sets).
This change ensures that the selection in the Patch History is kept
when the user navigates to the previous or next file diff.
Bug: issue 999
Change-Id: I19cafedd8a11683dca4a24fbebbcacf63425fe62
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* stable:
Support different color pallete when not signed in
Send new patchset event after its available
Enable git:// download URLs if canonicalGitUrl set
Fix NPE on Gerrit startup if mail.from doesn't include a name
Add config setting to only suggest users which are in a visible group
Change-Id: I2bc9ca40e616c7f7b0c12de41f631c916439289c
If the user is not signed in a different theme of colors can be
applied to the UI, making it more obvious that login is necessary.
Bug: issue 913
Change-Id: Id8c780042740b3b93dcee7ed84b3f9f6be06d9de
Signed-off-by: Shawn O. Pearce <sop@google.com>
If the administrator has set gerrit.canonicalGitUrl but has left the
download.scheme variable unset to its default, assume they want to use
git:// as a type of download and enable it.
Bug: issue 966
Change-Id: I8f6d5c5a3d16821d07c61f16bce9680a7e0721e5
Signed-off-by: Shawn O. Pearce <sop@google.com>
The access panel should be read-only when it opens, even if the user
has write permission. If the access panel is in read-only mode the
overview is better since the UI does not contain the controls for
editing the access rights. For users that have the permission to edit
the access rights there is an 'Edit' button to switch the access
panel into edit mode.
Bug: issue 956
Change-Id: I04b1072750455932779e95a0f7424b8fd4198901
Signed-off-by: Stefan Lay <stefan.lay@sap.com>
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Permissions are stored in the project.config file within the
refs/meta/config branch of each project. This makes the rules
more flexible in the future, as well as adds version control.
For example:
[access "refs/*"]
owner = group tools-owners
[access "refs/heads/*"]
label-Verified = -1..+1 group tools-dev
label-Verified = -1..+1 group tools-owners
label-Code-Review = -2..+2 group tools-owners
submit = group tools-dev
submit = group tools-owners
[access "refs/heads/stable"]
exclusiveGroupPermissions = read create push
read = group Anonymous Users
push = group tools-repo-maintainer
To enable easy remote editing of the configuration rules, the
following access block is added by default to -- All Projects --
and is thus inherited throughout the entire site:
[access "refs/meta/config"]
read = group Project Owners
push = group Project Owners
This configuration section permits any project owner or site
administrator (as they are indirectly always a project owner of
any project) to push changes to the project.config file within
the refs/meta/config branch, updating access (and other project
information) remotely without using the web UI.
Change-Id: Idb56f657a4bf88108ad40bbb19d831e6806b68c5
Signed-off-by: Shawn O. Pearce <sop@google.com>
The ref_rights table is about to change its entire data model to
something stored in Git, and which uses a different layout in-memory
and on-disk than the old RefRight object. Dropping the old web UI
before making the internal API changes reduces the amount of code that
is being modified at once. A new UI will be built from scratch to
support the new data model more accurately than the old simple table
layout could do.
Change-Id: Idfdebc712b1241a81346084037bc5f6aeab6e42a
Signed-off-by: Shawn O. Pearce <sop@google.com>
Despite our best efforts to resolve warnings, some new ones slipped in
late this afternoon.
Change-Id: I4b8f8bba08de2d5c7a2a03c04d121c0e447bfa8e
Signed-off-by: Shawn O. Pearce <sop@google.com>
Keys cannot be registered until the prior screen has dropped its key
bindings. Move the activation of the current patch set into the
registerKeys() routine of ChangeScreen, where its legal to register
(or re-register) the key bindings.
Change-Id: I24bba5a09bd9f1452e01bdb5685e2b332aa51106
Signed-off-by: Shawn O. Pearce <sop@google.com>
Support diff between patches in the change screen. Allow changing
patches base comparison.
All displayed patches can now have their files listed and compared
to target branch or to a specific patch of the change.
Bug issue: 194
Change-Id: I617cbe647338b8a4fb71788f04ab6e2c952780fc
Pass through arguments for diff between patch sets
Modify internal APIs to pass through the old, new and preferences
needed to compute the differences between two patch sets for the
UI.
Bug: issue 194
Change-Id: I98827bf88227e912860769f22cd90f5c35b784b0
The 'Publish and Submit' action is not atomic. This means if the
submit fails the comments and approvals will still be published.
If the screen stays with the PublishCommentScreen on submit failure
there is no indication for the user that the comments and approvals
were actually published. To make this more obvious we now go back to
the change screen before displaying the submit error. On the change
screen the user can then see that the comments and approvals were
successfully published.
Bug: issue 963
Change-Id: I9fcfd6b89b53db6f672d79714c6942fa953e5dd9
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Move to the new Scheduler API. It hasn't been deprecated yet.
Change-Id: Icfe5d6a53f362a97e798afae9f8eb984b13e8ae5
Signed-off-by: Shawn O. Pearce <sop@google.com>
We always use the DefaultSuggestionDisplay so its reasonable to
perform the downcast here to that type in order to control the
UI as we want it to behave.
Change-Id: Id48fdaf59ece74abe67773c800f23c3b8312ff3c
Signed-off-by: Shawn O. Pearce <sop@google.com>
The get*TimeFormat functions were deprecated, replace with getFormat and
specific predefinedFormat fields.
Change-Id: Ib2e7a44b75f3d8dcaf2d683466cefd310de126bd
Parent commit id and short message is placed in a Grid that expands
vertically when a patch set has more than one parent. The text
"Initial Commit" is used when a patch set has no parents.
Change-Id: I5775e8e09b506d9a97d0303e0ba150a926a091e8
If submit fails when a user presses 'Publish and Submit' in the
PublishCommentsScreen the form stays disabled so that now it's not
possible to publish the voting and the comments without submitting
(because the 'Publish' button is disabled). Now it's also not
possible to copy a typed in summary comment to the clipboard.
This change ensures that the form gets re-enabled if the submit
fails.
Change-Id: I75a0c55e98d064c4b64eaa78dac30ac202bf411f
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
There is a bug in gwt 2.1.0 [1] that prevents that pressing the ENTER
key is properly recognized and so actions that are connected with
pressing ENTER are not triggered.
Examples:
- confirming a query in the query input field with ENTER does not
trigger the query
- confirming the login information in the UserPassSignInDialog with
ENTER does not trigger the login
- confirming to add a reviewer in the ChangeScreen with ENTER does
not add the reviewer
This problem only affects some browsers (e.g. Firefox, older versions
of Google Chrome).
The new code was tested with Google Chrome 11.0.696.68,
Firefox 3.6.17, Firefox 4.0.1 and Internet Explorer 8.0.7600.1685.
[1] http://code.google.com/p/google-web-toolkit/issues/detail?id=5558
Bug: issue 946
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Change-Id: Ia61ba2fbd150e1c587d7c40252d500e28a99711b
Support fast dev cycle through maven profiles that build GWT for specific
browser user agents.
To build for only webkit based browsers you can now do:
mvn package -Psafari
Change-Id: I1d7ca64413cb6e2d937e2a3a09f53bf1a9e2ffbc
Java applets are disappearing on the web; many browsers disable them
by default either by browser vendor choice, operating system developer
choice, or local corporate policy.
Strip this code out so we don't need to maintain it.
Change-Id: Ib28506aedeb684c76d948cf14025e9cb630892ea
Signed-off-by: Shawn O. Pearce <sop@google.com>
Future versions of Maven may not support declaring the same plugin
twice within the build element. Move the two executions together into
one plugin.
Change-Id: I95eab0131203e45810bb7cf15e17d7e54598c519
Signed-off-by: Shawn O. Pearce <sop@google.com>
If the default text color is made to be a light color, the buttons
aren't readable because the browser default background for the button
will also usually be a light color.
Bug: 915
Change-Id: Ic26ace7f678f1bf6f273302aa25c68f55398365b
Signed-off-by: Shawn O. Pearce <sop@google.com>
Make the "Show Inherited Rights" checkbox mechanism on the
project access screen, cause inherited rights to also be
hidden when a refright is added and the refrights table is
reloaded.
Change-Id: I4691750ffce4616b53bb57e3a06857d294dde972
While returning to the Change using "UpToChange" link in any
patchset, always the latest patchset is activated. This commit
modifies the functionality of the "UpToChange" link by storing
the last browsed patchset and activating it on return. This
makes it easy to review older patchsets.
Bug: issue 822
Change-Id: Iaf01c53797d92434a0bc150f73ad232aec3619d6
This change adds a new item to the group configuration: a list of
groups whose members should be included in this one. This makes it
possible to set up a hierarchy of included groups, which can make it
easier to maintain complex access control lists.
To accomplish this, two new database tables were added,
called AccountGroupIncludes and AccountGroupIncludesAudit.
The relevant support code was added around them, largely based on
the existing code for handling indivdual account membership. In
addition, caches for group information were added, paralleling the
caches that already exist for accounts.
Change-Id: Ib6990c17739f28f38bc13961143db7ce79251567
When this property is set on a group, actions and
comments from members of this group will only cause
emails to be sent to change authors. This is
particularly useful to quiet actions from automation
users.
Change-Id: Ibcde6e07045ec00d095028c86e8dd47cef3cf582
Ian Wienand