We don't push our code to a Maven repository, so there only reason
to construct source archives is to feed source files into the GWT
compiler. Move the source plugin onto only the packages that we
feed into the GWT code, allowing the others to skip this step.
This fixes a "bug" in a later change that adds the Prolog Cafe
translater to the build process. Without this change first, the
Prolog Cafe translator is firing twice for every Prolog source file
that is part of our standard build.
Change-Id: Iba38aa371ce7c8950ac30dc3cf06e01b465afb5a
Signed-off-by: Shawn O. Pearce <sop@google.com>
This way we can set the Eclipse warnings/error reporting for the
generated code to ignore problems we normally try to prevent in
human written sources.
Change-Id: I0b32d4ebf95611f58468a14e81489bf76f5d7603
Signed-off-by: Shawn O. Pearce <sop@google.com>
Version 2.3.0 contains at least one bad thread locking bug where
locks are grabbed but not released in the LDAP cache, resulting in
the server eventually being unable to service any requests without
a JVM restart.
Move back to 1.7.2, a version that we have proven to be stable in
production servers.
Change-Id: I2db36dbb7a3b74435d20de64c3dbb687d4f1c580
Signed-off-by: Shawn O. Pearce <sop@google.com>
This reverts commit e7db8b6de0.
The 7.4.0 release seems to have issues with SSL certificates. We are
getting millions of log entries like:
...
3166773 [2011-05-09 14:22:52,556] WARN org.eclipse.jetty.util.log : javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
3166774 [2011-05-09 14:22:52,556] WARN org.eclipse.jetty.util.log : javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
3166775 [2011-05-09 14:22:52,556] WARN org.eclipse.jetty.util.log : javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
3166776 [2011-05-09 14:22:52,556] WARN org.eclipse.jetty.util.log : javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
3166777 [2011-05-09 14:22:52,556] WARN org.eclipse.jetty.util.log : javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
...
Revert the upgrade until upstream is can fix the issue.
Conflicts:
pom.xml
Change-Id: I75f58d0cf99555ae5ead75fae232b75553076a79
Java applets are disappearing on the web; many browsers disable them
by default either by browser vendor choice, operating system developer
choice, or local corporate policy.
Strip this code out so we don't need to maintain it.
Change-Id: Ib28506aedeb684c76d948cf14025e9cb630892ea
Signed-off-by: Shawn O. Pearce <sop@google.com>
This fixes the keepalive@jsch.com error seen by some sites.
Change-Id: I19917d91ddeb2ab55119c71ea60e90d2034ab460
Signed-off-by: Shawn O. Pearce <sop@google.com>
It is necessary to use at least this revision in order to get the
new functionality of merging Git notes available to Gerrit. Gerrit
will make use of this functionlity to finish the implementation of
the change 20045.
Change-Id: I406d3b708187fb7b15660f89dbcdf108d5d0fba7
Signed-off-by: Sasa Zivkov <sasa.zivkov@sap.com>
We need to use gwtjsonrpc 1.2.3 as it has support for the
newer GWT remote APIs.
Change-Id: I83bfe72d51611d4ee6f201f524c45d3ec2d020ed
Signed-off-by: Shawn O. Pearce <sop@google.com>
This version resolves issues with the rename detector getting
stuck in an infinite loop on certain types of large files.
Change-Id: Ie01d0a3154de2f67f53942a24909f38cb9cb2fcc
Signed-off-by: Shawn O. Pearce <sop@google.com>
This version correctly ignores the keepalive messages sent by
the paramiko python SSH client.
Change-Id: Iac23cc53027ffc748fc2ed933288fcf1585b48bb
Signed-off-by: Shawn O. Pearce <sop@google.com>
The new version contains a work-around for failed sftp connections,
resolving a common NullPointerException error in server error logs.
Change-Id: Iebe667e8cd81cb79848833e2a5de68447fcd42fa
Signed-off-by: Shawn O. Pearce <sop@google.com>
This fixes an issue with the default HistogramDiff implementation,
which was marking large unmodified regions as though they were
replaced by the author of a change.
Change-Id: Iec1ec815dce51319a9491e35f8906a6dd10f129e
Signed-off-by: Shawn O. Pearce <sop@google.com>
This version fixes the DiffFormatter to correctly consider inserted
blank lines near the end of a file.
Change-Id: I67111a39dd3c8214e119ee53da8a12d2b628e172
Signed-off-by: Shawn O. Pearce <sop@google.com>
This version of JGit switches the DiffFormatter factory to use
HistogramDiff by default, which is derived from patience diff and
tends to produce more readable results on source code.
Change-Id: Ic9218e899f24d8d6d65334f9d5986f7b75a1feac
Signed-off-by: Shawn O. Pearce <sop@google.com>
This version fixes missing object errors identified during branch
level access control checks when receiving a push from a client.
It also corrects a pack stream corruption created while packing a
large delta compressed file as a whole object.
Change-Id: Ic67064ce5bc086331caf7ee76620de11318d62c1
Signed-off-by: Shawn O. Pearce <sop@google.com>
This fixes a bug in the path quoting in the patch cache, which caused
"@2" in a filename to disappear in the web UI.
We can also now take advantage of DiffFormatter's ability to
do rename detection for us, as well as configure the streaming
threshold from gerrit.config (via the WindowCache).
Bug: issue 706
Change-Id: Id45676bdeb5a73035472ea5e27c2c4ec94d4b9dc
Signed-off-by: Shawn O. Pearce <sop@google.com>
ReceivePack now includes the full stack trace when an unpack error
occurs. This should help track down strange issues being seen with
some pushes.
Change-Id: I404f902c5a096f4d3b2df37108b273826dbca196
Signed-off-by: Shawn O. Pearce <sop@google.com>
This fixes the 'error: unpack failed: error daad993f7' message were
were seeing during some uploads to Gerrit servers. The receive
code was choking on an object larger than the stream threshold
size, because it didn't try to coerce the object's loader into a
flat byte[].
Change-Id: Id3616536c0f703bef6c69fbc6bf354e17c8474f9
Signed-off-by: Shawn O. Pearce <sop@google.com>
This resolves an incorrect data corruption error when packing
objects for transport that are delta encoded.
Change-Id: Ic501a46e31595dd08bccf9469c0b139671b9dc12
Signed-off-by: Shawn O. Pearce <sop@google.com>
* stable: (30 commits)
Clarify the upgrade instructions
Draft release notes for 2.1.5
documentation: Document why hook --change-url might be missing
documentation: Fix rendering errors in gerrit.config
Allow ; and & to seperate parameters in gitweb
Include a quick summary of the size of a change in email
Display the size of a patch (lines added/removed)
Fix clearing of topic during replace
Fix inherited Read Access +2 not inheriting
Add some basic RefControl tests for delegated ownership
Fix branch owner adding exclusive ACL
Optimize RegexFilePredicate for common matches
Correct copyright headers to AOSP
Don't expose /COMMIT_MSG as a modified file in ChangeData
Don't enable dk.brics.automaton's optional syntax
Fix NPE while matching file:^ pattern on deleted files
Fixed unused imports in OutgoingEmail
Don't show /COMMIT_MSG in change emails
Fix NPE during merge failure on new branch
Honor user's syntax coloring preference in unified view
...
Conflicts:
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/patch/PatchScriptBuilder.java
gerrit-server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java
gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java
gerrit-server/src/main/java/com/google/gerrit/server/mail/CommentSender.java
gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java
gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCacheImpl.java
gerrit-server/src/main/java/com/google/gerrit/server/patch/Text.java
Change-Id: I80bfdb55872fa4bdf4f751c337b609e7ec809605
Pressing 'c' to open a comment editor on the current line also
put a 'c' in the editor's text box. This was fixed by adding a
preventDefault() during dispatch inside of GlobalKey and is picked
up by upgrading to a newer gwtexpui.
Ctrl-S and Ctrl-D were performing the default browser actions to
save the current page and bookmark the current page. The issue
here was WebKit doesn't support the keypress handler in a text box.
Instead we have to use keydown handlers to capture the event.
Just switching to the keydown handler however caused focus to be
lost on the table when the editor closed, because Chrome doesn't know
where to send focus when the currently focused widget is destroyed.
Adding in explicit blur() requests through setFocus(false)
immediately before we make the text area not visible, read-only,
or deleted from the DOM allows the global keys to work as expected
after the current event is done.
Bug: issue 431
Bug: issue 639
Change-Id: I08732be288f1149073d85bc5e09ab4cfb6547f8f
Signed-off-by: Shawn O. Pearce <sop@google.com>
I meant to keep reusing the 2.1 version number for the entire
2.1 series during development, but botched it during the 2.1.4
development cycle and set it to 2.1.4-SNAPSHOT by mistake. Put
it back to 2.1-SNAPSHOT since 2.1.4 is released.
Change-Id: I37e206c0609bf3fd94a5aab8ea301c98b7fb013e
Signed-off-by: Shawn O. Pearce <sop@google.com>
Setup the velocity context and add basic objects to it. Add
a few velocity helper functions, but do not use any of it.
Allows default email templates to be in the war file and to
be overridden by placing an appropriately named template in
<site>/etc/mail.
Change-Id: I45cdbbcd19929ce52c54a5c9b8ee510b52681ed3
This fixes an issue with rename detection computing the wrong number
of common blocks between files.
Change-Id: Ib0a03a9d93e267bba5fab2c4c8f5ce8335d6b10b
Signed-off-by: Shawn O. Pearce <sop@google.com>
Ian Wienand