Commit Graph

21 Commits

Author SHA1 Message Date
James E. Blair c6a59489fa Initial commit of git-restack
Change-Id: I5508816fcd5c6362ee17a494ae8b997de29505d3
2015-12-18 16:29:55 -08:00
Jeremy Stanley 55a91a6655 Fix H238 violation and enable check for that rule
Change-Id: I04f3d96acfc0be12393cc6cf5f0d3f7006939532
2015-06-17 00:53:01 +00:00
Jeremy Stanley 7a4f2553d6 Update to newer hacking checks
Update to newer hacking checks, and temporarily disable H238 to be
fixed in a subsequent patch.

Change-Id: I7d59ca5680f958852f73e705e45454a1c4d1c800
2015-06-17 00:49:19 +00:00
Doug Hellmann b6aab6d9d6 Split README.rst into separate doc files
Split up the README into separate documentation files so we can publish
the documentation for git-review.

Change-Id: Idcdf43e73c5ca5b8cb239606236e3b2a660c46b7
2015-02-03 17:38:50 +01:00
Jeremy Stanley 213f99515c Work toward Python 3.4 support and testing
Change-Id: Ie5b0ac8763a0d137e0aa99b05102d2aa76f60034
2014-09-03 19:00:09 +00:00
Christian Berendt d3b91e326e Enabled hacking checks H305 and H307
* H305  imports not grouped correctly
* H307  like imports should be grouped together

Change-Id: Ia4b376a90fed830ceea4b91caa920ff38263df5e
2014-07-17 09:38:36 +02:00
Jeremy Stanley 59e7414d2a Update requirements to OpenStack's recommendations
This synchronizes requirements.txt, test-requirements.txt and
setup.py with the current state of the openstack/requirements
global-requirements.txt list. Also adds flake8 exclusions to tox.ini
for new hacking rules with which git-review does not yet comply.

Change-Id: I837ba57134bea16dd46c3f512bccd51cb39f76c8
2014-07-03 14:54:14 +00:00
Clark Boylan a4a7f3c491 Reduce testr concurrnecy to 2.
Hard set testr concurrency to 2 so that fewer gerrit instances are
started in parallel compared to the default testr concurrency setting.
This will help avoid contention for memory and process resources when
running the tests.

Change-Id: Id3837500ce243af8d8ef762c6dcf50146876f406
2014-02-14 13:13:54 -08:00
Jeremy Stanley 8fd1a948c3 Remove tox locale overrides
* tox.ini: The LANG, LANGUAGE and LC_ALL environment overrides were
introduced originally during the testr migration in an attempt to be
conservative about the possibility that locale settings in the
calling environment could cause consistency problems for test runs.
In actuality, this should be unnecessary and any place where it does
cause issues ought to be considered an actual bug. Also, having
these in the configuration actively causes older pip to have
problems with non-ASCII content in some package metadata files under
Python 3, so drop it now.

Change-Id: I8747a52141321549c56214710b70c5838aacc84e
Closes-Bug: #1277495
2014-02-10 03:02:11 +00:00
Dina Belova e99aa8b16d Implement integration tests.
Provide intergation testing for the git-review utility. Requires
Gerrit war file (like 2.6.1-gerrit.war) in the .gerrit directory in
the git-review project (like git-review/.gerrit/2.6.1-gerrit.war).

Tests start local Gerrit and create test user and project there to
be used.

Closes-Bug: 1048724
Change-Id: I3242479dcbcf230085178004540992680f3f8e30
2013-08-15 21:08:08 +00:00
Dina Belova d73c473b19 Migrate to pbr.
For ease of future source code maintenance by OpenStack developers,
git-review is now adopting the same Python Build Reasonableness as
used by current OpenStack projects.

Closes-Bug: 1179007
Change-Id: I20427b51e84b90dcc1d870a547cdcc5240b4ff0e
2013-08-15 20:42:37 +00:00
Jeremy Stanley 08f878bc02 Pin hacking <0.6
* tox.ini: Newer hacking fails to recognize the Apache header in the
git-review script, so pin at <0.6 for now to match an upcoming
refactoring change. This will allow us to get some quick cosmetic
fixes in first.

Change-Id: I8e92b1d23d0b8d87e3bafe43d97c987abdf1d9f8
2013-08-08 05:00:16 +00:00
Jeremy Stanley 8cebdcdb12 Fix pep8 deps for pyflakes version conflict.
Fixes bug 1199400.

* tox.ini: In the pep8 environment, flake8 and hacking were both
listed as deps. This was fine while both worked with the latest
pyflakes, but then pyflakes 0.7.3 came along and was getting
installed before the more explicit pyflakes 0.7.2 requirement was
parsed for hacking. Since flake8 is in the requirements list for
hacking anyway, this just removes it from the pep8 environment deps
list.

Change-Id: I647235a4f6d109e00f13a156c57ff3a0e9a13a81
2013-07-09 15:08:51 +00:00
Clark Boylan e131460c82 Add venv testenv to tox.ini.
The automagic pypi publishing of releases through jenkins.openstack.org
depends on tox having a testenv called venv. Add this new testenv so
that git-review can be released automagically.

Change-Id: I89d78a22c13f94b5af3cda1115c8068424d42b34
2013-04-05 13:45:29 -07:00
Monty Taylor a221915447 Align to OpenStack Hacking guidelines.
Change-Id: I8eeea3be46d4943c462772de26b10142f426a00c
2013-04-04 16:22:14 -07:00
Monty Taylor 3be868a923 Switch to flake8 from pep8.
Change-Id: Ib7e1e51e644dbdfc530a7c5ca3005dd73ffa3f79
2013-04-04 16:22:14 -07:00
James E. Blair a4b99206bf Revert to 1.17.
1.17 was the last version that met the basic criteria of helping
first time developers sucessfully make their first commit.  That's
the most important task of git-review.  Revert all changes since
that version.  Unfortunately, some of the minor bug fixes since then
will have to be re-written because 1.18, in addition to introducing
basic bugs, also introduced significant code reorganization.

Addresses bug 1038269.

Re-fixed pep8 errors since we've become more strict since 1.17.

Change-Id: Ia3495a6bb883ddf08155c6bfb69a58d19a15a804
2012-09-30 16:39:08 -07:00
Clark Boylan b0e75ededd Configure a pep8 tox environment.
Configure a pep8 tox environment so that git-review can make use of the
standard OpenStack pep8 test job.

Change-Id: I4d655a6fc86bbbf6b594b7b35570e75951aef7ab
2012-09-27 14:29:29 -07:00
Mark McLoughlin ea5ed21d73 Fix pep8 errors with 1.3.1
Also, pin to 1.3.1 so that we don't break as soon as the next
pep8 version comes out.

Change-Id: Ic9d7f7c75e9140e607801728c55858c26cf56621
2012-06-25 21:58:59 +01:00
Monty Taylor 284871b691 Freeze requirements for sdist packages.
Use installed virtualenv to determine the list of actual
dependent versions tested.

Change-Id: Iff9781e97f32a318e357ae1d3305a74e2b3ba479
2012-01-27 15:37:44 -05:00
Monty Taylor 3cf55f98ac Added tox support for testing pep8.
We'll process requirements.txt to install depends as needed.
Also include a hacking doc explaining what we expect.
Also, including argparse automatically breaks our automagic version
numbering, so import it in main() (slightly evil, but not terrible)

Change-Id: Ib3f65459fe2cd54ce531b7ae22935e24bd8f8920
2012-01-26 18:55:10 -05:00