opendev
/
git-review
Code Issues Proposed changes

Add a note on Windows and Unicode 

Add a rough note on what we've discovered about Windows and Unicode.
tl;dr use Python 3.6+

Change-Id: I219cfca6cb9ad427a55a7a1821f9fe0a9cf632f3
This commit is contained in:
Ian Wienand 2017-11-17 09:31:36 +11:00
parent bbea22f773
commit 2ee19d3526
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
doc/source/installation.rst
View File

@ -18,6 +18,16 @@ after installing the dependencies listed in requirements.txt
.. note:: ``git-review`` requires git version 1.8 or greater.
Windows
-------
The Windows ``cmd`` console has a number of issues with Python and
Unicode encodings which can manifest when reviews include non-ASCII
characters. Python 3.6 and beyond has addressed most issues and is
recommended for Windows users. For earlier Python versions,
modifying the local install with `win-unicode-console
<https://github.com/Drekin/win-unicode-console>`__ may also help.
Setup
=====