opendev
/
git-review
Code Issues Proposed changes

show the config value result after fetching it in verbose mode 

We show the command used to retrieve the config value, but don't show
what we find. Fix that, and also show cases where we are going to use
the default setting.

Change-Id: I53ee9ea6e3af4e951587c0845c8333874238f0c2
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2017-10-19 18:27:19 -04:00
parent b61f5b2ec9
commit 84511b1124
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
git_review/cmd.py
View File

@ -278,9 +278,14 @@ def git_config_get_value(section, option, default=None, as_bool=False):
__, git_dir = git_directories()
cmd[2:2] = ['-f', os.path.join(git_dir, 'config')]
try:
return run_command_exc(GitConfigException, *cmd).strip()
result = run_command_exc(GitConfigException, *cmd).strip()
if VERBOSE:
print(datetime.datetime.now(), "result:", result)
return result
except GitConfigException as exc:
if exc.rc == 1:
if VERBOSE:
print(datetime.datetime.now(), "using default:", default)
return default
raise