gerrit: Make triggerOn* parameters really use boolean values.
Parameters triggerOn* are documented as boolean, however, using values like true or false results in exception "TypeError: cannot serialize True (type bool)". Theses values have special meaning in yaml, and are not loaded as string in python. It was hence required to use quotes to make it work. Add a sample using thoses attributes as an example. Change-Id: Iccbda8ebc0867e173fa7ccab78db16874ddb2a45 Reviewed-on: https://review.openstack.org/24262 Reviewed-by: James E. Blair <corvus@inaugust.com> Reviewed-by: Khai Do <zaro0508@gmail.com> Reviewed-by: Anita Kuno <akuno@lavabit.com> Approved: Jeremy Stanley <fungi@yuggoth.org> Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Tested-by: Jenkins
This commit is contained in:
parent
a0ccb45c57
commit
2370375aee
|
@ -99,19 +99,19 @@ def gerrit(parser, xml_parent, data):
|
|||
XML.SubElement(gtrig, 'silentMode').text = 'false'
|
||||
XML.SubElement(gtrig, 'escapeQuotes').text = 'true'
|
||||
XML.SubElement(gtrig, 'triggerOnPatchsetUploadedEvent').text = \
|
||||
data['triggerOnPatchsetUploadedEvent']
|
||||
str(data['triggerOnPatchsetUploadedEvent']).lower()
|
||||
XML.SubElement(gtrig, 'triggerOnChangeMergedEvent').text = \
|
||||
data['triggerOnChangeMergedEvent']
|
||||
str(data['triggerOnChangeMergedEvent']).lower()
|
||||
XML.SubElement(gtrig, 'triggerOnCommentAddedEvent').text = \
|
||||
data['triggerOnCommentAddedEvent']
|
||||
str(data['triggerOnCommentAddedEvent']).lower()
|
||||
XML.SubElement(gtrig, 'triggerOnRefUpdatedEvent').text = \
|
||||
data['triggerOnRefUpdatedEvent']
|
||||
str(data['triggerOnRefUpdatedEvent']).lower()
|
||||
if 'overrideVotes' in data and data['overrideVotes'] == 'true':
|
||||
XML.SubElement(gtrig, 'gerritBuildSuccessfulVerifiedValue').text = \
|
||||
str(data['gerritBuildSuccessfulVerifiedValue'])
|
||||
XML.SubElement(gtrig, 'gerritBuildFailedVerifiedValue').text = \
|
||||
str(data['gerritBuildFailedVerifiedValue'])
|
||||
if data['triggerOnCommentAddedEvent'] == 'true':
|
||||
if data['triggerOnCommentAddedEvent']:
|
||||
XML.SubElement(gtrig, 'commentAddedTriggerApprovalCategory').text = \
|
||||
data['triggerApprovalCategory']
|
||||
XML.SubElement(gtrig, 'commentAddedTriggerApprovalValue').text = \
|
||||
|
|
|
@ -0,0 +1,16 @@
|
|||
- job:
|
||||
name: test-gerrit-trigger
|
||||
triggers:
|
||||
- gerrit:
|
||||
triggerOnChangeMergedEvent: true
|
||||
triggerOnCommentAddedEvent: true
|
||||
triggerOnPatchsetUploadedEvent: true
|
||||
triggerOnRefUpdatedEvent: false
|
||||
triggerApprovalCategory: CRVW
|
||||
triggerApprovalValue: 2
|
||||
failureMessage:
|
||||
projects:
|
||||
- projectCompareType: 'PLAIN'
|
||||
projectPattern: 'myproject'
|
||||
branchCompareType: 'PLAIN'
|
||||
branchPattern: 'master'
|
Loading…
Reference in New Issue