jjb
/
jenkins-job-builder
Code Issues Proposed changes

fixed config format for nodejs plugin 

Updates generated config for nodejs
to match current configuration format.

Change-Id: Ie2642cc81d7dcf176c3d826120850dfaa1811150
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
This commit is contained in:
Sorin Sbarnea 2018-04-28 10:15:02 +01:00
parent 53523f9727
commit 89b531613c
No known key found for this signature in database
GPG Key ID: B85725D917D27B8A
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
jenkins_jobs/modules/wrappers.py
View File

@ -1814,8 +1814,11 @@ def nodejs_installator(registry, xml_parent, data):
/../../tests/wrappers/fixtures/nodejs-installator001.yaml
"""
npm_node = XML.SubElement(xml_parent,
'jenkins.plugins.nodejs.tools.'
'NpmPackagesBuildWrapper')
'jenkins.plugins.nodejs.'
'NodeJSBuildWrapper')
version = registry.get_plugin_info('nodejs').get('version', '0')
npm_node.set("plugin", "nodejs@" + version)
mapping = [('name', 'nodeJSInstallationName', None)]
convert_mapping_to_xml(npm_node, data, mapping, fail_required=True)

4
tests/wrappers/fixtures/nodejs-installator001.xml
View File

@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<project>
<buildWrappers>
<jenkins.plugins.nodejs.tools.NpmPackagesBuildWrapper>
<jenkins.plugins.nodejs.NodeJSBuildWrapper plugin="nodejs@0">
<nodeJSInstallationName>latest node</nodeJSInstallationName>
</jenkins.plugins.nodejs.tools.NpmPackagesBuildWrapper>
</jenkins.plugins.nodejs.NodeJSBuildWrapper>
</buildWrappers>
</project>