opendev
/
lodgeit
Code Issues Proposed changes

Replace XXX with TODO 

Change-Id: I3f8af83d85a2a2b8d7c1e1723a5962e17938f8cd
This commit is contained in:
David Pursehouse 2015-11-07 12:50:29 -08:00
parent fbb61e9c1d
commit 2acd8c9881
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lodgeit/controllers/pastes.py
View File

@ -23,7 +23,7 @@ from lodgeit.lib.captcha import check_hashed_solution, Captcha
class PasteController(object):
"""Provides all the handler callback for paste related stuff."""
# XXX:dc: using language here clashes with internationalization terms
# TODO(dc): using language here clashes with internationalization terms
def new_paste(self, language=None):
"""The 'create a new paste' view."""
language = local.request.args.get('language', language)
@ -155,7 +155,7 @@ class PasteController(object):
style_name = local.request.form.get('style')
resp = redirect(local.request.headers.get('referer') or
url_for('pastes/new_paste'))
# XXX:dc: use some sort of form element validation instead
# TODO(dc): use some sort of form element validation instead
if style_name in STYLES:
resp.set_cookie('style', style_name)
return resp

2
lodgeit/lib/json.py
View File

@ -37,7 +37,7 @@ class JSONRequestHandler(object):
kwargs = {}
else:
raise TypeError('arguments as object or list expected')
# XXX:dc: use flatland to validate these args before passing onward
# TODO(dc): use flatland to validate the args before passing onward
response = {
'data': self.funcs[method_name](*args, **kwargs),
'error': None

4
lodgeit/models.py
View File

@ -43,7 +43,7 @@ class Paste(db.Model):
language = 'text'
self.code = u'\n'.join(code.splitlines())
self.language = language
# XXX:dc: set these a bit more sanely, allowing two types is bad
# TODO(dc): set these a bit more sanely, allowing two types is bad
if parent_id:
self.parent_id = parent_id
self.pub_date = datetime.now()
@ -90,7 +90,7 @@ class Paste(db.Model):
"""Get the new replies for the ower of a request and flag them
as handled.
"""
# XXX:dc:clean this query up to just return the ids
# TODO(dc): clean this query up to just return the ids
ids = [x.paste_id for x in Paste.query.filter_by(
user_hash=local.request.user_hash).all()]
paste_list = Paste.query.filter(db.and_(