openstack
/
project-config
Code Issues Proposed changes

Create 'Review-Priority' for designate repos 

This allows anyone in the group "designate-release-manager"
to set the priority of patches, and block non freeze patches
during RC.

This allows for more precise dashboard than relying
on stars from PTLs, and allows the team to distingush
between a procedural -2 and a release freeze -2.

Change-Id: Id7b4c6b219899fa7ed86554257264af7efe20408
This commit is contained in:
Graham Hayes 2016-03-21 12:08:57 +00:00
parent be0a78da3a
commit fdb962758c
6 changed files with 69 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gerrit/acls/openstack/designate-dashboard.config
View File

@ -3,6 +3,7 @@ abandon = group designate-core
abandon = group horizon-core
label-Code-Review = -2..+2 group designate-core
label-Code-Review = -2..+2 group horizon-core
label-Review-Priority = -1..+2 group designate-release-manager
label-Workflow = -1..+1 group designate-core
label-Workflow = -1..+1 group horizon-core
@ -21,6 +22,18 @@ label-Workflow = -1..+1 group Project Bootstrappers
label-Workflow = -1..+1 group designate-stable-maint
label-Workflow = -1..+1 group horizon-stable-maint
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze
value = 0 No Priority
value = +1 Important Change
value = +2 Gate Blocker Fix / Urgent Change
[receive]
requireChangeId = true
requireContributorAgreement = true

13
gerrit/acls/openstack/designate-specs.config
View File

@ -1,8 +1,21 @@
[access "refs/heads/*"]
abandon = group designate-core
label-Code-Review = -2..+2 group designate-core
label-Review-Priority = -1..+2 group designate-release-manager
label-Workflow = -1..+1 group designate-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze
value = 0 No Priority
value = +1 Important Change
value = +2 Gate Blocker Fix / Urgent Change
[receive]
requireChangeId = true
requireContributorAgreement = true

13
gerrit/acls/openstack/designate-tempest-plugin.config
View File

@ -1,9 +1,22 @@
[access "refs/heads/*"]
abandon = group designate-tempest-plugin-core
label-Code-Review = -2..+2 group designate-tempest-plugin-core
label-Review-Priority = -1..+2 group designate-release-manager
label-Verified = -1..+1 group designate-ci
label-Workflow = -1..+1 group designate-tempest-plugin-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze
value = 0 No Priority
value = +1 Important Change
value = +2 Gate Blocker Fix / Urgent Change
[receive]
requireChangeId = true
requireContributorAgreement = true

13
gerrit/acls/openstack/designate.config
View File

@ -1,6 +1,7 @@
[access "refs/heads/*"]
abandon = group designate-core
label-Code-Review = -2..+2 group designate-core
label-Review-Priority = -1..+2 group designate-release-manager
label-Verified = -1..+1 group designate-ci
label-Workflow = -1..+1 group designate-core
@ -16,6 +17,18 @@ label-Workflow = -1..+0 group Change Owner
label-Workflow = -1..+1 group Project Bootstrappers
label-Workflow = -1..+1 group designate-stable-maint
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze
value = 0 No Priority
value = +1 Important Change
value = +2 Gate Blocker Fix / Urgent Change
[receive]
requireChangeId = true
requireContributorAgreement = true

13
gerrit/acls/openstack/python-designateclient.config
View File

@ -1,6 +1,7 @@
[access "refs/heads/*"]
abandon = group designate-core
label-Code-Review = -2..+2 group designate-core
label-Review-Priority = -1..+2 group designate-release-manager
label-Workflow = -1..+1 group designate-core
[access "refs/heads/stable/*"]
@ -18,6 +19,18 @@ label-Workflow = -1..+1 group designate-milestone
[access "refs/tags/*"]
pushSignedTag = group library-release
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze
value = 0 No Priority
value = +1 Important Change
value = +2 Gate Blocker Fix / Urgent Change
[receive]
requireChangeId = true
requireContributorAgreement = true

4
tools/normalize_acl.py
View File

@ -58,7 +58,10 @@ out = ''
valid_keys = {'abandon',
'access',
'copyAllScoresIfNoCodeChange',
'copyAllScoresOnTrivialRebase',
'copyMaxScore',
'copyMinScore',
'create',
'defaultValue',
'exclusiveGroupPermissions',
@ -66,6 +69,7 @@ valid_keys = {'abandon',
'forgeCommitter',
'function',
'label-Code-Review',
'label-Review-Priority',
'label-Rollcall-Vote',
'label-Workflow',
'label-Verified',