Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I4f8f403452416a1b6203684e1b6d7b5e2743dce3
Since the beaker jobs are being run on xenial, we need a special nodeset
for it, otherwise beaker gives an error:
beaker-hostgenerator was not able to use this value as input.
Exiting with an Error.
We also want to install puppet from the Ubuntu repos rather than from
puppetlabs, since puppetlabs doesn't support puppet 3 for Xenial. For
centos we can keep the install process the same.
Change-Id: Ifd2244ae9dd212b2475f9cd6adb994bc058a4769
Depends-On: Ife2993b07dd995fc97676c002a91d0e695407522
There are two observed failures with 2.1:
* Our group hiera files are not being copied over.
* ansible_module_puppet_post_puppetdb.py causes a "MODULE FAILURE".
Change-Id: I79fd382180dfe3b024fdcdab8a5a984800fad336
Pulling inventory from puppetmaster was a neat hack, but it was also
a hack. Let's stop providing it.
Depends-On: Ic6809ed0b7014d7aebd414bf3a342e3a37eb10b6
Change-Id: I6bb66cecca8c3ddd6d2cef2a05324faa67ca98c2
As discussed on another project patches when introducing tests[1], we
would like to keep the tests closer to the where we apply the spec.
This change makes the testing structure consistent to the feedback given
on puppet-bandersnatch discussion.
[1] https://review.openstack.org/#/c/221941/
Change-Id: I7d0d1dc856f03f422fa5331a98f20d5661c462be
Co-Authored-By: Danilo Ramalho <dramalho@thoughtworks.com>
Add acceptance tests for puppet-ansible module so that once the module
is applied we check if files were created and packages were installed.
Co-Authored-By: Bruno Tavares <btavare@thoughtworks.com>
Change-Id: Ic569a70737f7e9d0a86c14e1f299b308ab9d3986
Use same target directory for zuul-cloner and
the regular git command.
Change-Id: Iff07b9151a98059e1bbcc13139307f91273488d5
Co-Authored-By: Fabien Boucher <fabien.boucher@enovance.com>
Andreas Jaeger