The opendev project has been moving away from puppet and this is one of
the puppet modules that is no longer used. To simplify things for us we
are taking the extra step of retiring this repo.
Change-Id: I39beec7d543a7343d52aaa1fbf0f833b28178693
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I0e4916fb253816cbeef2c5cb8bfe90b727173bca
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I7d12c87b38a2798753c9d46d2015837556506d74
Variables with numbers for names are valid as regex capture groups in
puppet 4[1], so this check is not beneficial and can be
counterproductive when we do actually want to have numeric variables.
[1] https://docs.puppetlabs.com/puppet/latest/reference/lang_variables.html#naming
Change-Id: Ic71cf6027b5e1af38a4e048e78e7a321c3b0849c
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins.
Change-Id: I477cef5fc5297b8d078b3cf29a6a02fda6abecc6
Clark Boylan