Commit Graph

9 Commits

Author SHA1 Message Date
Clark Boylan a4162cfb80 Retire this repo
The opendev project has been moving away from puppet and this is one of
the puppet modules that is no longer used. To simplify things for us we
are taking the extra step of retiring this repo.

Change-Id: I050a5fa329c4925940b93a162bb54901555f4b47
2022-02-17 11:26:53 -08:00
Colleen Murphy f4ddcabc87 Update Gemfile for Zuulv3
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.

Change-Id: Ib5f25bad8e5be39530113bf19ea2951cc9344961
2018-07-12 09:57:43 +02:00
Colleen Murphy 7abbdafc62 Depend on helper gem for spec_helper_acceptance
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.

Change-Id: I1bfeb46bb500bff1cefb581b0bf1e2fa7df7b0e8
2017-08-18 10:41:43 +02:00
Spencer Krum 237495f0a4 Use new infra_spec_helper for gem dependencies
Change-Id: I2c2816688c6eec1f4bac617448613e0df38949a6
2016-06-21 18:37:39 -07:00
Spencer Krum afb337c784 Pin google-api-client; sanitize Gemfile
Change-Id: I2fcb6ade3867d39cc48989652c1915727bb8d847
2016-04-14 15:16:53 -07:00
Paul Belanger a437a8524a Remove invalid comment
Change-Id: I467db6ffde445977a1056f087e12134308cda027
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2015-07-24 12:52:09 -04:00
Colleen Murphy f95ff9b0a7 Remove puppet-lint-numericvariable gem
Variables with numbers for names are valid as regex capture groups in
puppet 4[1], so this check is not beneficial and can be
counterproductive when we do actually want to have numeric variables.

[1] https://docs.puppetlabs.com/puppet/latest/reference/lang_variables.html#naming

Change-Id: I8f1213128a7513b5257013c42019c0be31c06ef9
2015-07-21 19:34:04 -07:00
Colleen Murphy 9dee51a91b Enable puppet-lint-empty_string-check & fix errors
This patch changes the default values of params whose values were '' to
undef, except for $askbot::site::ssl::site_ssl_cert_file and
$askbot::site::ssl::site_ssl_key_file which were changed to use the
same default provided in the askbot and askbot::config class. Also
updated conditionals to look for the new undef value instead of the
empty string.

Change-Id: Ia3cabb5760f940cbf9c39714571b2ae5eac92a2d
2015-07-09 18:20:08 -07:00
Colleen Murphy a07962ba55 Add Gemfile and puppet 4 checks
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. This patch also
corrects lint errors caught by the puppet-lint-absolute_classname-check
gem.

We disable the puppet-lint-empty_string-check gem to be corrected by a
follow-up patch.

We disable the disable_arrow_alignment check in the Rakefile.
Previously, the system version of puppet-lint that was being run by
'rake lint' was too old to catch this. When using 'bundle exec rake
lint' the gem is new enough to catch this. Whether we want to actually
fix these lint errors is a different discussion, so this patch disables
it for now.

Change-Id: I2b2c8511367b2e97c30b7681125d9063b3e78a86
2015-07-09 17:37:05 -07:00