The opendev project has been moving away from puppet and this is one of
the puppet modules that is no longer used. To simplify things for us we
are taking the extra step of retiring this repo.
Change-Id: I46c786779b8f8d5b7dd836250de10f259744b5b5
Discussion following https://review.openstack.org/#/c/200854/ confirmed
that we do want to enforce this check. This patch re-enables the check
and fixes lint errors that fail the check.
Change-Id: I39cdaa5c26668f7815460c489fcde543a57e9a01
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. This patch also
corrects lint errors caught by the puppet-lint-absolute_classname-check
and puppet-lint-empty_string-check gems.
We disable the disable_arrow_alignment check in the Rakefile.
Previously, the system version of puppet-lint that was being run by
'rake lint' was too old to catch this. When using 'bundle exec rake
lint' the gem is new enough to catch this. Whether we want to actually
fix these lint errors is a different discussion, so this patch disables
the check for now.
Change-Id: Ib44f2d6ac941e6fed118a5ff78bddd3d0f0a40b5