The opendev project has been moving away from puppet and this is one of
the puppet modules that is no longer used. To simplify things for us we
are taking the extra step of retiring this repo.
Change-Id: I4c99ae4ea9924c97357ebf909f267976872a9323
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I321ff4eef6e6af095ad1856bc29cbaf8c449efbc
This adds support for blacklisting the mirroring of certain packages.
This requires a very new bandersnatch running under python3.
Change-Id: I0de38d79947bbae10650879b0fbdc77db0131918
If the bandersnatch source is set to pip3 then install bandersnatch from
pip under python3. This will allow us to install current bandersnatch and
use newer features like package blacklisting.
Change-Id: I97d8e0ef5a1fb75c513b7f87d6f015f57cd42df6
In the run script, fix a latent regression involving purging of
stale URLs, where the wrong variable name was used.
Change-Id: I78795e86033e1a60364e27c65575854c68bc1c05
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I7a23414094109add8afefc2dbddf863091994403
Since the beaker jobs are being run on xenial, we need a special nodeset
for it, otherwise beaker gives an error:
beaker-hostgenerator was not able to use this value as input.
Exiting with an Error.
We also want to install puppet from the Ubuntu repos rather than from
puppetlabs, since puppetlabs doesn't support puppet 3 for Xenial. For
centos we can keep the install process the same.
Change-Id: Ifd2244ae9dd212b2475f9cd6adb994bc058a4769
Depends-On: I256e71092acf13d6296c23abc70f11ce692a2efb
Bindep is a tool for checking the presence of binary packages needed
to use an application / library. It started life as a way to make it
easier to set up a development environment for OpenStack projects.
Change-Id: I256e71092acf13d6296c23abc70f11ce692a2efb
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Because the world regularly loses its collective mind when living under
the aegis of the god known as SemVer, clearly it's ok to break users when you
do it while bumping the major version.
Humble supplicants that we are, bowing before the mightiness and
righteous glory that places developer convenience and code cleanliness
over actual users actually using the actual software, we must prostrate
ourselves and beg for forgiveness while pinning the software to the
previous working version so that our users can have a mirror that works.
Woe betide us that we do not honor the obession with discarding
compatibility and rushing madly headlong into the abyss of the future.
Clearly we are not worthy to sit at the right hand of Tom the father and
his legion of cohorts, but instead must actually run a production
service.
Change-Id: If7bcf7cd93ac0e22d3294e401556f6642389f039
I mistakenly assumed in I2b5822a7383b8f2f49958c8268453333dabe52cc that
this module would update the installed version of bandersnatch.
Installing from pip, we want to get the latest release.
Change-Id: I6a1f213a3127f57b41b4ec7e3f128b1bbde2ae37
We can't assume bandersnatch hasn't run yet after puppet is done since
it runs on a cron it could start running even while puppet is still
running. Instead just assert that it does its job after it should have
run. This fixes a test failure due to the racyness that existed
previously.
Change-Id: I3f919c9dbd762c1dc603e24899a7ced16d1165a0
In 2940279 management of the apache vhost was split into a separate
class and the vhost_name parameter was removed from the
bandersnatch::mirror class. This wasn't done in a backwards compatible
way and the acceptance tests were never updated to use the new API.
Additionally, a88c399 split the bandersnatch cron job out of the mirror
class into its own class, so the test for the existence of the job was
failing. This patch updates the tests to use the new classes and to
stop using the now invalid parameter.
We also relax some of the internal system assertions and opt instead
for checking that the service is working correctly by curling the
endpoints and checking the contents. This exposed an issue on CentOS
where selinux was not allowing apache to serve the robots.txt file, so
also added an selinux rule to the fixture.
Change-Id: If724c51b72f634a95bbffd080a9d33234a5d7645
Order and intendation of those parameters are changed
to follow Puppet Style Guide recommendation [0].
Moreover, it will allow to an user to find much faster
a variable in a list of variables.
[0]. https://docs.puppetlabs.com/guides/style_guide.html
Change-Id: I4cce6b8e972c45d2a23e57e747de7b9ef0d691a3
Add acceptance tests for puppet-bandersnatch module so that once the
module is applied we check if files were created, packages were
installed and services were started.
Change-Id: Iaa1e27842351d834d469f76d5aabe54ff49bd089
Co-Authored-By: Bruno Tavares <btavare@thoughtworks.com>
Use same target directory for zuul-cloner and
the regular git command.
Change-Id: I4dba0ed8c6b81bde89302a6b2660718956bd897a
Co-Authored-By: Fabien Boucher <fabien.boucher@enovance.com>
Variables with numbers for names are valid as regex capture groups in
puppet 4[1], so this check is not beneficial and can be
counterproductive when we do actually want to have numeric variables.
[1] https://docs.puppetlabs.com/puppet/latest/reference/lang_variables.html#naming
Change-Id: I131cdc5c7ee2d6bae23766c078711a616bc1575a
puppet-httpd is the openstack-infra version of puppetlabs-apache
(0.0.4) release.
This patchset will remove the puppetlabs-apache namespace from -infra
allowing for possible future patchsets to use newer puppetlabs-apache
modules.
Change-Id: I84a0882a18fb83a6eff7a3c1a27aea2813baf7f0
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Discussion following https://review.openstack.org/#/c/201399/ confirmed
that we do want to enforce this check. This patch re-enables the check
and fixes lint errors that fail the check.
Change-Id: I1d3fd00f025aba1abf9b723ea58c99e8458ee5b6
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. This patch also
corrects lint errors caught by the puppet-lint-absolute_classname-check
gem.
Change-Id: I419a1354d76cda4c6b177bcab0eb7ff7866410f6