The opendev project has been moving away from puppet and this is one of
the puppet modules that is no longer used. To simplify things for us we
are taking the extra step of retiring this repo.
Change-Id: I4c99ae4ea9924c97357ebf909f267976872a9323
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I321ff4eef6e6af095ad1856bc29cbaf8c449efbc
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I7a23414094109add8afefc2dbddf863091994403
Add acceptance tests for puppet-bandersnatch module so that once the
module is applied we check if files were created, packages were
installed and services were started.
Change-Id: Iaa1e27842351d834d469f76d5aabe54ff49bd089
Co-Authored-By: Bruno Tavares <btavare@thoughtworks.com>
Variables with numbers for names are valid as regex capture groups in
puppet 4[1], so this check is not beneficial and can be
counterproductive when we do actually want to have numeric variables.
[1] https://docs.puppetlabs.com/puppet/latest/reference/lang_variables.html#naming
Change-Id: I131cdc5c7ee2d6bae23766c078711a616bc1575a
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. This patch also
corrects lint errors caught by the puppet-lint-absolute_classname-check
gem.
Change-Id: I419a1354d76cda4c6b177bcab0eb7ff7866410f6