The opendev project has been moving away from puppet and this is one of
the puppet modules that is no longer used. To simplify things for us we
are taking the extra step of retiring this repo.
Change-Id: I1f88638b300d3c961fba87e51c0df31e48241ef9
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I99a4f3e1c104ffeff35eb29c4dbf5f452db44cd1
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: Ie3fc3263e520b1313825225b4094c8ce923d22db
Variables with numbers for names are valid as regex capture groups in
puppet 4[1], so this check is not beneficial and can be
counterproductive when we do actually want to have numeric variables.
[1] https://docs.puppetlabs.com/puppet/latest/reference/lang_variables.html#naming
Change-Id: I29d2e7f34f12ddb594c6ceabee0978fa5dc940f4
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins.
This patch also corrects errors caught by the
puppet-lint-empty_string-check gem. It makes the
$bugdaystats::site::configfile and $bugdaystats::site::httproot
parameters required since the file resources named after them could not
possibly work if they were left undefined or empty string. The
parameter $bugdaystats::site::serveradmin is currently unused in this
module, so we make it optional and default to undef in preparation for
when this functionality is added.
Change-Id: I9eef9a8d49c1ca597783b19fbbbe0129c6157cd5
Clark Boylan