Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: If86144ecaf206ada80aebae350504c0d51495dff
In 3f1f51 we added most of the boilerplate needed to run beaker-rspec
tests, but we still need the beaker-rspec gem itself. This patch adds
the gem to the Gemfile and reorganizes the Gemfile following
puppet-openstackci's model.
Change-Id: Ifc1ee3c62693680c425f0ca7962f9a716e16ce11
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. This patch also
corrects lint errors caught by the puppet-lint-absolute_classname-check
and puppet-lint-empty_string-check gems as well as arrow alignment
which wasn't being caught under the system version of puppet-lint.
Change-Id: I7b9efb0fce3b59d611aa9aaaf6899bc6e6cc62b0
Monty Taylor