The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I6923d679c1e499e1e1451bc250173603211ec133
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I090e8ed3c8dbaf5f1a23cf09806d9dbc03c5f143
Add acceptance tests for puppet-elasticsearch module so that once the
module is applied we check if files were created, packages were
installed and services were started.
Co-Authored-By: Danilo Ramalho <dramalho@thoughtworks.com>
Change-Id: Id902337b8f6ca3210644f9401002755d9f6b3e0b
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins.
Change-Id: I4bb194d3eedea05f4bbfa9b70920793e2b30d10c
Clark Boylan