Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I090e8ed3c8dbaf5f1a23cf09806d9dbc03c5f143
Since the beaker jobs are being run on xenial, we need a special nodeset
for it, otherwise beaker gives an error:
beaker-hostgenerator was not able to use this value as input.
Exiting with an Error.
We also want to install puppet from the Ubuntu repos rather than from
puppetlabs, since puppetlabs doesn't support puppet 3 for Xenial. For
centos we can keep the install process the same.
Additionally, this patch updates params.pp to distinguish between JRE
packages based on the Ubuntu release so that these module will work on
Xenial. We still keep support for trusty.
Finally, remove spec assertions that are not useful, including
verifications that packages are installed and config files existing. It
is enough to assume that if the puppet ran without errors that it was
able to also successfully find and install packages and lay down config
files. We remove these tests instead of updating the package check for
the new JRE package.
Change-Id: Ifd2244ae9dd212b2475f9cd6adb994bc058a4769
Depends-On: I053d437ceb7895fe2b1e2c46bf9cf19f73bdb20c
Add acceptance tests for puppet-elasticsearch module so that once the
module is applied we check if files were created, packages were
installed and services were started.
Co-Authored-By: Danilo Ramalho <dramalho@thoughtworks.com>
Change-Id: Id902337b8f6ca3210644f9401002755d9f6b3e0b
Use same target directory for zuul-cloner and
the regular git command.
Change-Id: Iddd6ca6b4e1d8d2ec90d7aa7013068f172928f1c
Co-Authored-By: Fabien Boucher <fabien.boucher@enovance.com>
Clark Boylan