summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorClark Boylan <clark.boylan@gmail.com>2017-02-13 17:44:43 -0800
committerClark Boylan <clark.boylan@gmail.com>2017-02-13 17:44:43 -0800
commit4034168e71770448356e77d12586a1170e48573e (patch)
tree9a91d81723021a28408073bc0ee0c7d8577f8cf6
parent521672bc3525f8c73ecfe0e2ffd9901b381ccb3a (diff)
Don't use npm list --parseable
Turns out we lose version info with --parseable (so not sure in what world this is parseable output) so stop using the --parseable flag. This corrects behavior where we reinstall ethercalc every puppet run which can upgrade unpinned dep libs in ways that break them on older node (we are using the ethercalc prescribed node but its a little old). Change-Id: Ib9aebecf3a0c36c50e5069b1a871886e4ddb1a42
Notes
Notes (review): Code-Review+2: Joshua Hesketh <joshua.hesketh@rackspace.com> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Tue, 14 Feb 2017 02:07:18 +0000 Reviewed-on: https://review.openstack.org/433386 Project: openstack-infra/puppet-ethercalc Branch: refs/heads/master
-rw-r--r--manifests/init.pp2
1 files changed, 1 insertions, 1 deletions
diff --git a/manifests/init.pp b/manifests/init.pp
index 8241a48..b72fb72 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -69,7 +69,7 @@ class ethercalc (
69 69
70 exec { 'install-ethercalc': 70 exec { 'install-ethercalc':
71 command => "npm install ethercalc@${ethercalc_version}", 71 command => "npm install ethercalc@${ethercalc_version}",
72 unless => "npm ls --parseable | grep ethercalc@${ethercalc_version}", 72 unless => "npm ls | grep ethercalc@${ethercalc_version}",
73 path => $path, 73 path => $path,
74 cwd => $base_install_dir, 74 cwd => $base_install_dir,
75 require => Anchor['nodejs-anchor'], 75 require => Anchor['nodejs-anchor'],