summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorColleen Murphy <colleen.murphy@suse.de>2018-07-24 11:25:53 +0200
committerColleen Murphy <colleen.murphy@suse.de>2018-08-09 20:56:27 +0200
commitfe5d375e4aedbccb164d490a17fa82e68d5534da (patch)
treef36dd7329ac705221b480e68bfd52344ad4aa9d5
parent15c133270b78002a0b93f44263c76660339409a0 (diff)
Turn off binary symlink in nodejs module
On Xenial, the nodejs puppet module tries to create a symlink from /usr/bin/node to /usr/bin/nodejs. Depending on the resource ordering, this might happen before or after the nodejs package creates its own /usr/bin/node. If puppet has the chance to make the symlink itself, it breaks node by creating a broken link cycle. This patch uses the legacy_debian_symlinks parameter to prevent the puppet module from doing that. This problem was fixed and the option was deprecated and removed in later versions of the nodejs puppet module, so we will have to remove the parameter if we update the nodejs module. Change-Id: I61e591dbeabe4c043f87b04a7c56c0539120f8a5
Notes
Notes (review): Code-Review+2: Ian Wienand <iwienand@redhat.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 10 Aug 2018 20:16:27 +0000 Reviewed-on: https://review.openstack.org/585291 Project: openstack-infra/puppet-ethercalc Branch: refs/heads/master
-rw-r--r--manifests/init.pp5
1 files changed, 3 insertions, 2 deletions
diff --git a/manifests/init.pp b/manifests/init.pp
index 48484ea..befe402 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -84,8 +84,9 @@ class ethercalc (
84 84
85 if ($use_nodejs_version != 'system') { 85 if ($use_nodejs_version != 'system') {
86 class { '::nodejs': 86 class { '::nodejs':
87 repo_url_suffix => $use_nodejs_version, 87 repo_url_suffix => $use_nodejs_version,
88 before => Anchor['nodejs-package-install'], 88 legacy_debian_symlinks => false,
89 before => Anchor['nodejs-package-install'],
89 } 90 }
90 } else { 91 } else {
91 package { ['nodejs', 'npm']: 92 package { ['nodejs', 'npm']: