opendev
/
puppet-ethercalc
Code Issues Proposed changes

Fix defined type namespacing 

Without this patch, puppet 4 apply tests can't find the mod defined type
and fail with:

  Evaluation Error: Resource type not found: Mod at /etc/puppetlabs/code/modules/ethercalc/manifests/apache.pp:43:15

This patch ensures the resource reference is namespaced the same way the
resource declaration is already.

Change-Id: I891572c245f878a198f972e33e7ddbff74a5a731
This commit is contained in:
Colleen Murphy 2018-04-26 17:39:40 +02:00
parent 31e44bbcb0
commit 7a3b3c6f81
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
manifests/apache.pp
View File

@ -40,22 +40,22 @@ class ethercalc::apache (
ssl => true,
}
if !defined(Mod['rewrite']) {
if !defined(Httpd::Mod['rewrite']) {
httpd::mod { 'rewrite':
ensure => present,
}
}
if !defined(Mod['proxy']) {
if !defined(Httpd::Mod['proxy']) {
httpd::mod { 'proxy':
ensure => present,
}
}
if !defined(Mod['proxy_http']) {
if !defined(Httpd::Mod['proxy_http']) {
httpd::mod { 'proxy_http':
ensure => present,
}
}
if !defined(Mod['proxy_wstunnel']) {
if !defined(Httpd::Mod['proxy_wstunnel']) {
httpd::mod { 'proxy_wstunnel':
ensure => present,
}
@ -66,7 +66,7 @@ class ethercalc::apache (
ensure => present,
}
}
if !defined(Mod['auth_openid']) {
if !defined(Httpd::Mod['auth_openid']) {
httpd::mod { 'auth_openid':
ensure => present,
require => Package['libapache2-mod-auth-openid'],