The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I677a2ca36099e3d1157e41bae72d71ec56f1adc1
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I2d36dbc5790dbd97509f52210f313c7e2e5be8df
All our puppet projects rely on a Gemfile for tests
to run. This was missing, so add here as well.
Also fix the linter errors that this new Gemfile
addition is causing.
Change-Id: I24143df44c313ea76472649bb9a6fa0ce4536307