This updates the tests to test installation for the same version of
etherpad that we are running in production.
Change-Id: I3624b79a8bb2c9c362037d1b025a3df9bf7c701f
In an earlier change we set up npm installations to happen in the eplite
user's homedir rather than in the log dir. We did this because with
systemd we no longer have a log dir on all installations. The etherpad
lite plugin installation was still attemping to use the log dir which
doesn't work on newer systems.
Update this plugin installation process to use the homedir like the
normal installation process.
Also add plugin installation to the tests we run to test this works now.
Change-Id: I5cff75c89b16d61c4902c920259b82463306833e
On Xenial, the nodejs puppet module tries to create a symlink from
/usr/bin/node to /usr/bin/nodejs. Depending on the resource ordering,
this might happen before or after the nodejs package creates its own
/usr/bin/node. If puppet has the chance to make the symlink itself, it
breaks node by creating a broken link cycle. This patch uses the
legacy_debian_symlinks parameter to prevent the puppet module from doing
that. This problem was fixed and the option was deprecated and removed
in later versions of the nodejs puppet module, so we will have to remove
the parameter if we update the nodejs module.
In this case, on puppet 3 a quirk of the resource ordering was causing
the module not to be idempotent since the second puppet run would change
the file to a symlink, so this patch has the side benefit of also
allowing us to add a test for idempotency. With that second puppet run,
the etherpad service now has enough time to fully start up and we can
uncomment the curl test.
Change-Id: Ic834ad6f0828cc2d20810e48bb053f9b14659c4a
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I2d36dbc5790dbd97509f52210f313c7e2e5be8df
Add a xenial nodeset and update the spec helper to install puppet 3 from
the Ubuntu repos instead of from puppetlabs.
Change-Id: I62fd4d69358dfb31ec5f328e116e9fd06e743d5b
Use same target directory for zuul-cloner and
the regular git command.
Change-Id: I57e34c58760f1571f79649f85d739b192476f834
Co-Authored-By: Fabien Boucher <fabien.boucher@enovance.com>
Monty Taylor