The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I673fc19ab3d254c3a58b7a250d0877aac4838f71
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: Ic60a4664b47f1f3d37e3dc8831ef620aa128db0a
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins.
Change-Id: Id272e95c5f93e07b5ab7791badc635eb066c6763
Co-Authored-By: Colleen Murphy <colleen@gazlene.net>
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Monty Taylor