The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I66ee4529d821acd41663a83fc371d36de0333fcd
Looking at puppet-openstackci, it seems this is the logic needed to
start using our centralized spec helper scripts.
Change-Id: I5b21f6fe14bf288f27f45e0b6c0e58db35b64d71
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
We split the definition of the module under test from its preconditions.
This behaviour was identified while testing puppet-zuul. To keep it
consistent across projects, we decided to also apply the same logic on
this module.
Change-Id: I0b9014ce6470d5c142ab6a3b281ea7401f88e738
Co-Authored-By: Bruno Tavares <btavare@thoughtworks.com>
Co-Authored-By: Danilo Ramalho <dramalho@thoughtworks.com>
Add acceptance tests for puppet-gerrit module so that once the module is
applied we check if files were created, packages were installed and
services are available to users.
We left one pending test because this module is still not idempotent.
Co-Authored-By: Caio Carrara <ccarrara@thoughtworks.com>
Co-Authored-By: Dhiana Deva <ddeva@thoughtworks.com>
Change-Id: I88b5730d369578ae6763226c0424467286e753a2
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix errors
caught by the puppet-lint-absolute_classname-check gem and arrow
alignment errors that weren't being caught before.
This patch leaves the puppet-lint-empty_string-check commented out for
now since there are too many parameters with empty string defaults.
Change-Id: I0b8cf61bd71f7875b9741fff78aef40c5bc513bd
Monty Taylor