Previously gerritbot installed from a release version. So any change
to gerritbot requires a new release of gerritbot before it can come
into effect.
Change it to install the current git master branch for gerritbot and
use that.
Change-Id: Id229306960a9aa6ccf6241662e7172fce8150d33
In local testing doing a pip upgrade of gerritbot did work. So remove
setting where it would never upgrade.
Snippet from doing an upgrade inside a virtualvenv:
$ pip install -U gerritbot
<snip>
Installing collected packages: pbr, paho-mqtt, gerritbot
Found existing installation: pbr 0.5.23
Uninstalling pbr-0.5.23:
Successfully uninstalled pbr-0.5.23
Found existing installation: gerritbot 0.2.0
Uninstalling gerritbot-0.2.0:
Successfully uninstalled gerritbot-0.2.0
Successfully installed gerritbot-0.3.0 paho-mqtt-1.2 pbr-0.11.1
Change-Id: I155e40c380bcf4904ffc4c294b8261e3e0e1d74f
Order and intendation of those parameters are changed
to follow Puppet Style Guide recommendation [0].
Moreover, it will allow to an user to find much faster
a variable in a list of variables.
[0]. https://docs.puppetlabs.com/guides/style_guide.html
Change-Id: I6620fb9d5f1ec867c6af4e900094c97735fe8fcb
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-empty_string-check and
puppet-lint-absolute_classname-check gems.
Change-Id: I923739c6997287509e75b37643ea0abe171a9faf
Without this patch, the gerritbot module makes the nick, password,
server, vhost_name, user, and channel_file parameters optional by
providing default values for them. The default values are empty
strings, which are not valid and will cause the bot to not function
properly. This patch changes the vhost_name paremeter to have a default
value of $::fqdn, which is a reasonable default, and makes the other
parameters required by removing the defaults since there are no sane
defaults to provide.
This will mean that puppet runs will fail if no values are supplied to
these parameters. However, Infra is already providing values in
system-config, and other users of this module must be providing values
in order for gerritbot to work, so this should not be a destructive
change.
Change-Id: Ia0eed0f3e8341715236c7dee78840ed4443ddf90
Mostly documentation and parameterised class parameter complaints.
Change-Id: I5b3ffa4ad3f707f385165c2d86c891c6bd4c1ae0
Reviewed-on: https://review.openstack.org/16901
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Change-Id: I49e63755b8b5bf60673cf37b62371b3f299e3bbe
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-on: https://review.openstack.org/14971
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
More fixes in preparation for our gate-ci-puppet-lint job.
Change-Id: I1cd3499e6cd958fbbacd01f3daef581a7b4d3217
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-on: https://review.openstack.org/13764
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Pip doesn't appear to be able to do a clean upgrade of gerritbot on
oneiric. It should remove the old versions of gerritbot after installing
the new versions but it does not. This confuses Puppet into thinking
that it need to reinstall gerritbot 0.1.2 on each puppet run which
restarts the IRC bot. To prevent this behavior ensure the package is
present and not latest.
Change-Id: I7729d126a7811b7e08541ed65ca48f4dc302ff6b
Reviewed-on: https://review.openstack.org/11955
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Configure gerritbot to log into /var/log/gerritbot.
Change-Id: I24f8602eaa0f779de9d455cda8ad692f932ebd39
Reviewed-on: https://review.openstack.org/11939
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
gerritbot.confg should be gerritbot.config
Change-Id: I9532226a690a986ae8480c1cfbd89e23cf1f3ac1
Reviewed-on: https://review.openstack.org/11905
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Stop using the gerritbot script within the puppet tree. Use the
upstream gerritbot implementation from pypi instead.
Remove old gerritbot script, use pip to install upstream gerritbot,
and update init script to find new location, of the gerritbot script.
Change-Id: I62afe404b1c4d130901e54ca4e7857bb71b4cdd8
Reviewed-on: https://review.openstack.org/10676
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Monty Taylor