Commit Graph

15 Commits

Author SHA1 Message Date
Paul Belanger 5bb58dc4d7
Update pip provider to use openstack_pip provider
Change-Id: I9fcfe12a2aecb99be0dd36e6a5a57e45f56533ca
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2016-06-16 13:00:34 -04:00
Andrey Nikitin bfe2669891 Order of the class parameters is refactored
Order of those parameters is changed
to follow Puppet Style Guide recommendation [0].
Moreover, it will allow to an user to find much faster
a variable in a list of variables.

[0]. https://docs.puppetlabs.com/guides/style_guide.html

Change-Id: I560d954fc6daf6eff6fac5b4d2b582d338986303
2016-03-21 11:53:10 +03:00
Colleen Murphy ba456bfa1a Add Gemfile and puppet 4 checks
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix errors
caught by the puppet-lint-absolute_classname-check gem.

Change-Id: I860844dff7a64d32dd16f18a388af361c9cef263
2015-07-23 16:32:58 -07:00
Colleen Murphy ecb7018362 Fix class parameters
Values for the username, oauth_token, project_username, and
project_password parameters must be provided by the user. The empty
string is not a sane default and will cause broken deployments if used.
This change makes these parameters required. Infra is providing these
parameters in system-config so this change will not break Infra. If
downstream users are not providing these parameters their deployments
will not be functional, so this change should be safe for users already
using this class correctly.

The use of the projects parameter was removed in 15daf9a so it no
longer needs to be part of the parameter list. Infra is no longer using
the projects parameter in system-config so this change will not break
Infra. If downstream users still have this parameter as part of their
manifest, updating the module to this commit will break their puppet
runs, but not make any system changes.

Change-Id: Ic7d42f922ae436fe1b7b9bef21ca659ddedae432
2015-07-23 16:32:52 -07:00
James E. Blair b626425f88 Protect pygithub with proper capitalization.
Change-Id: I8a67a9781cc638138114da2eb870bcf856a37202
Reviewed-on: https://review.openstack.org/17272
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
2012-12-01 00:58:52 +00:00
James E. Blair c153dbb0a3 Fix jeepyb: protect pygithub requirement.
Change-Id: I6b4db1dc08342018cae6203cbecbee69956c5918
Reviewed-on: https://review.openstack.org/17261
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
2012-11-30 23:19:08 +00:00
Monty Taylor cbc3b43cdc Consume jeepyb.
Instead of keeping many of these files directly in the tree, use them
from the out-of-tree jeepyb project, which makes them easier to consume
for other people who are not us.

Change-Id: Id704f2e17dd80709ef63cbbf2c5475a08a835f91
Reviewed-on: https://review.openstack.org/16777
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
2012-11-30 18:02:30 +00:00
Matthew Wagoner 3f4bcb45e6 Clean up of minor puppet-lint warnings.
Mostly documentation and parameterised class parameter complaints.

Change-Id: Idbfd348a5befb041ce6eb36f9c6b195fc0c6799f
Reviewed-on: https://review.openstack.org/16685
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Approved: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins
2012-11-23 21:41:37 +00:00
Monty Taylor cf03da2d2b Attempt to more fully manage project creation.
Manage project creation via yaml files. Also,
Modify the manage_projects scripts to configure Gerrit project ACLs.
This change expects the project yaml to exist. The change will clone the
project for the localhost Gerrit install. It will then checkout the
meta/config ref, copy the ACL config file into the repo, commit, and
push to the origin. The ACL config location should be specified in the
projects.yaml file with the acl_config key.

For this to work the ACLs will need to be copied by Puppet from Puppet
to the Gerrit host. Add the file resource to do this as well.

Change-Id: I15a1ec13b381dce3c115c01c21f404ab79e72cc4
Reviewed-on: https://review.openstack.org/15352
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Approved: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins
2012-11-14 01:18:23 +00:00
Paul Belanger d9dc7332e0 Additional puppet-lint reformatting
Change-Id: I49e63755b8b5bf60673cf37b62371b3f299e3bbe
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-on: https://review.openstack.org/14971
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
2012-10-29 19:21:24 +00:00
James E. Blair d0404e17cb Add python-yaml to github module.
Change-Id: Id79068e1295cbc7ba01a2c9b8db7db40230a2296
Reviewed-on: https://review.openstack.org/14412
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Paul Belanger <paul.belanger@polybeacon.com>
Approved: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins
2012-10-13 15:47:27 +00:00
Monty Taylor 15daf9a9f2 Add support for initial project creation.
If replicate_local is set, this will ensure that /var/lib/git is created,
and that projects listed in the projects.config have repos there.

Additionally, it creates a new config file, projects.config which is a
yaml file listing all of the projects and various operational semantics about
them, such as whether or not they should have pull requests closed and whether
or not they track any remotes. This replaces remotes.config and github.config.

Moving forward, there is no reason to not have this script be able to
do github api calls to create the github repo if it's not there, set the
github project description, gerrit api calls to create the project in gerrit,
and initial project permissions templates.

Change-Id: I1ad803b0aa5f7386206d0c3f4cd858017242fe64
2012-08-02 15:49:02 +00:00
Monty Taylor 413161fd48 Fix all of the gerrit module problems.
Change-Id: I46001fd677bc9a3634c9860ec07438c326e908e3
2012-07-24 00:28:04 -05:00
Monty Taylor 4a741cd56f Move python-pip include to a class.
You can't have two different classes install the same package (FAIL)
But you can have two different classes include the same class, so
by encapsulating the "install pip" code into a module, we can safely
consume it across multiple modules.

Sometimes I really hate puppet.

Change-Id: I3467c52b6887298c1b4d01a29873c63edf0adfd3
2012-07-23 15:43:27 -05:00
Monty Taylor 644e41cfe5 Split github into its own module.
TODO: Add another script that sets the project description. Add the project
description to the config hash.

Change-Id: If4584b2a1e55e6eb912e1f557e31de216d49a516
2012-07-23 11:42:12 -05:00