Add Gemfile and puppet 4 checks

In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-absolute_classname-check gem.

Change-Id: I40b3eb70669133414681ab9c9a4272d46c4e83e2

.gitignore

@@ -0,0 +1,2 @@
+Gemfile.lock
+.bundled_gems/

Gemfile

@@ -0,0 +1,31 @@
+source 'https://rubygems.org'
+
+group :development, :test do
+  gem 'puppetlabs_spec_helper', :require => false
+
+  gem 'metadata-json-lint'
+  # This is nice and all, but let's not worry about it until we've actually
+  # got puppet 4.x sorted
+  # gem 'puppet-lint-param-docs'
+  gem 'puppet-lint-absolute_classname-check'
+  gem 'puppet-lint-absolute_template_path'
+  gem 'puppet-lint-trailing_newline-check'
+
+  # Puppet 4.x related lint checks
+  gem 'puppet-lint-unquoted_string-check'
+  gem 'puppet-lint-empty_string-check'
+  gem 'puppet-lint-leading_zero-check'
+  gem 'puppet-lint-variable_contains_upcase'
+  gem 'puppet-lint-numericvariable'
+  gem 'puppet-lint-spaceship_operator_without_tag-check'
+  gem 'puppet-lint-undef_in_function-check'
+
+  if puppetversion = ENV['PUPPET_GEM_VERSION']
+    gem 'puppet', puppetversion, :require => false
+  else
+    gem 'puppet', '~> 3.0', :require => false
+  end
+
+end
+
+# vim:ft=ruby

manifests/init.pp

@@ -29,7 +29,7 @@ class graphite(
                 'nodejs' ]
 
   include ::httpd
-  include pip
+  include ::pip
 
   package { $packages:
     ensure => present,
@@ -143,7 +143,7 @@ class graphite(
     require => File['/var/log/graphite'],
   }
 
-  include logrotate
+  include ::logrotate
   logrotate::file { 'querylog':
     log     => '/var/log/graphite/carbon-cache-a/query.log',
     options => [
@@ -256,8 +256,8 @@ class graphite(
   }
 
   file { '/usr/local/bin/graphite-init-db.py':
-    mode    => '0555',
-    source  => 'puppet:///modules/graphite/graphite-init-db.py'
+    mode   => '0555',
+    source => 'puppet:///modules/graphite/graphite-init-db.py'
   }
 
   file { '/etc/graphite/admin.ini':
@@ -270,18 +270,18 @@ class graphite(
   }
 
   file { '/etc/init.d/carbon-cache':
-    mode    => '0555',
-    source  => 'puppet:///modules/graphite/carbon-cache.init'
+    mode   => '0555',
+    source => 'puppet:///modules/graphite/carbon-cache.init'
   }
 
   file { '/etc/init.d/statsd':
-    mode    => '0555',
-    source  => 'puppet:///modules/graphite/statsd.init'
+    mode   => '0555',
+    source => 'puppet:///modules/graphite/statsd.init'
   }
 
   file { '/etc/default/statsd':
-    mode    => '0444',
-    source  => 'puppet:///modules/graphite/statsd.default'
+    mode   => '0444',
+    source => 'puppet:///modules/graphite/statsd.default'
   }
 
   service { 'carbon-cache':