The opendev project has been moving away from puppet and this is one of
the puppet modules that is no longer used. To simplify things for us we
are taking the extra step of retiring this repo.
Change-Id: Ibbd66faf35447c5e8587c6996cd5011fcede688a
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: Ifd7d38b683aeacd85906ebd26aba2db5c4d1bfac
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I2c1adf57f6d025d6e7fe9bc1dcb721b9961aac5f
Add acceptance tests for puppet-graphite module so that once the module
is applied we check if files were created, packages were installed and
services were started.
Change-Id: I54cf2e8e0cc484a8212d234efbf1d67df87583fd
Co-Authored-By: Danilo Ramalho <dramalho@thoughtworks.com>
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-absolute_classname-check gem.
Change-Id: I40b3eb70669133414681ab9c9a4272d46c4e83e2
Clark Boylan