Commit Graph

9 Commits

Author SHA1 Message Date
Clark Boylan 1609bb6a44 Fix leading :: on class includes to make linter happy
Why this needed to be a linter rule I do not know.

Change-Id: I27ba74c6060c9d2ad09b52bc38090ff9c1f83721
2020-03-05 09:14:07 -08:00
Bruno Tavares faf9d932ba Fix proxy and redirect configuration file names.
While working on puppet-lodgeit acceptance tests we found that the
configuration file that `httpd::mod::proxy` creates was not being picked
up by Apache because it was missing the prefix `.conf`. This transition
is required to configure httpd modules correctly on Apache >= 2.4

To prevent Apache from loading two the same configuration twice, we
remove the file without extension, so this change does not affect
running systems.

This change has fixes for `httpd::mod::proxy` and `httpd::mod::redirect`
as they have the same issue. We added tests as well to increase the
confidence on the fix.

The acceptance will be fixed on the follow-up patch, as the redirect
grants are broken for 2.4 as well.

Change-Id: I82241038d687316f91f18209fe8323c12422e2f8
Co-Authored-By: Danilo Ramalho <dramalho@thoughtworks.com>
2015-10-19 15:43:51 -02:00
Colleen Murphy 17430b7507 Add Gemfile and puppet 4 checks
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix errors
caught by the puppet-lint-unquoted_string-check and
puppet-lint-absolute_classname-check gems.

Change-Id: I9d74d25d2f2c95ec52a6db3bf070903240e1b933
2015-07-29 23:18:35 -07:00
Spencer Krum dab0f45bea Rename apache2 to httpd globally
This renames the classes and defined types from apache to httpd.
With the 'httpd' module available, we can migrate usage of 'apache'
to 'httpd.' Eventually this will free the 'apache' namespace.

A native ruby type and provider is contained in this class. It is
not namespaced to the class name so it has been renamed from a2mod
to httpd_mod.

Change-Id: I056eb28a13e7ccc95f1496019bedc332c17dd458
2015-02-05 05:49:30 -08:00
Ian Wienand 482441c9af Add rake "lint" target, fix errors
Add the rake "lint" target, and fix resulting minor errors, which were:

---
 manifests/mod/python.pp - WARNING: class not documented on line 1
 manifests/mod/wsgi.pp - WARNING: class not documented on line 1
 manifests/vhost.pp - WARNING: variable not enclosed in {} on line 80
 manifests/vhost.pp - WARNING: variable not enclosed in {} on line 82
 manifests/vhost/redirect.pp - WARNING: variable not enclosed in {} on line 43
 manifests/vhost/redirect.pp - WARNING: variable not enclosed in {} on line 45
---

Change-Id: I2213f314d4bf92b4ddf58dbb19a80783380a55ce
2014-11-20 10:56:33 +11:00
Eric Shamow 42c636341f Changes to match style guide and pass puppet-lint without error
No substantive behavior changes - only spacing, line alignment,
quotation, etc.
2012-04-20 21:07:54 -07:00
Walter Heck 42bc8ba49a changed name => path for file resources in order to name namevar by it's name 2012-04-16 15:31:54 +08:00
William Van Hevelingen 05fcec5f9c (#13073) Add missing puppet spec tests
This commit adds full puppet spec coverage
for all classes and defines.
2012-03-16 00:38:53 -07:00
Gary Larizza 57b904839b Commit apache::vhost::redirect Manifest 2011-07-15 15:27:50 -07:00