Commit Graph

5 Commits

Author SHA1 Message Date
Colleen Murphy e6cc42cbe3 Update Gemfile for Zuulv3
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.

Change-Id: I479bd357ae4483b91d401e83db719a5f6d968487
2018-07-12 09:57:44 +02:00
Colleen Murphy edceffecfa Depend on helper gem for spec_helper_acceptance
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.

Change-Id: Ib8c5c1bd7d4a5c7175623ed9dc53683d2f592786
2017-08-18 10:41:43 +02:00
Spencer Krum 7021dc9d7e Use new infra_spec_helper for gem dependencies
Change-Id: Ie4e445687ae5fa05e10afc5bd546b1592b84b8a9
2016-06-21 18:38:42 -07:00
Spencer Krum 2349ac7817 Pin google-api-client; sanitize Gemfile
Change-Id: I8660c9ecf8a644c2cce178e95830ef9f6897bfeb
2016-04-14 15:19:50 -07:00
Colleen Murphy ce4349d156 Add Gemfile and puppet 4 checks
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-absolute_classname-check gem as well
as arrow alignment errors not caught before.

Change-Id: I6ee8cc21247258d9a37ce3304c207c4b637378f7
2015-08-03 18:35:43 -07:00