The opendev project has been moving away from puppet and this is one of
the puppet modules that is no longer used. To simplify things for us we
are taking the extra step of retiring this repo.
Change-Id: I1494a2dd294c944f80f6cbe67cd96d7d39d70af7
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: Iaa342148a18948af00f2c661777797cc53da0868
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: Iaf0aa710b252fc61913a95ead55762eee6b31e6e
Add acceptance tests for puppet-lodgeit module so that once the module
is applied we check if files were created, packages were installed,
backup were configured and services were started.
Co-Authored-By: Danilo Ramalho <dramalho@thoughtworks.com>
Change-Id: I8dfce2cd0feb0d2ea5746383dde18e23d5d691ff
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-absolute_classname-check and
puppet-lint-empty_string-check gem as well as arrow alignment errors
not caught before.
The has_variable? function in the layout.html.erb template will return
true whether $image is set to empty string or undef, so we change the
template to look for nil so that the new default of undef will work
correctly.
Change-Id: I6738cfef08e0cf2faeabed469b9eff5e3c0bbb5a