Order and intendation of those parameters are changed
to follow Puppet Style Guide recommendation [0].
Moreover, it will allow to an user to find much faster
a variable in a list of variables.
[0]. https://docs.puppetlabs.com/guides/style_guide.html
Change-Id: I4dd4727f94132ce066d42aa87a246dd39c13553e
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-absolute_classname-check gem.
Change-Id: Icc120da2373214a9222e9434e725477096e989d3
Validate that the first option is a string.
Mutate the path to remove /'s, allowing full paths to be passed.
Change-Id: I341290c430023e5e9a24bf2247482ed818ea4a26
Mostly documentation and parameterised class parameter complaints.
Change-Id: I5b3ffa4ad3f707f385165c2d86c891c6bd4c1ae0
Reviewed-on: https://review.openstack.org/16901
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Change-Id: I4f7314bcb1cb58f94ff7a78aebe27ec4591fc11c
Reviewed-on: https://review.openstack.org/14187
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins
Stop using latest for packages installed by puppet. This way,
all system packages get updated, not just some random ones.
The unattended-upgrades config will email root. It is configured
for openstack servers and jenkins slaves, but not template hosts
so that it doesn't interfere with spin-up.
Also, fix some bits in the gerrit module that were causing
continuous restarts on gerrit-dev.
Install emacs.
Change-Id: I51c9083ccd3669f284fce4b50c36a37a0cac92d8