The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I6efe6cc34950e382656e39b579ff57566ed1e91a
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I20bf542923065f7790993e29938c71bfc189e447
Add acceptance tests for puppet-logstash module so that once the module
is applied we check if files were created, packages were installed and
users configured.
Co-Authored-By: Bruno Tavares <btavare@thoughtworks.com>
Change-Id: I0332e9caf732ab8874cd444a9faa42143d40e335
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-absolute_classname-check gem and arrow
alignment errors not caught before.
Change-Id: Icb76cc5019c378524344640e9670229e142a9627
Clark Boylan