Commit Graph

5 Commits

Author SHA1 Message Date
Colleen Murphy bd502ced88 Update Gemfile for Zuulv3
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.

Change-Id: Ic35f60eb6f400042e06a778b688287779e996045
2018-07-12 09:57:45 +02:00
Colleen Murphy 79471eb220 Depend on helper gem for spec_helper_acceptance
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.

Change-Id: If280787758be4ef18b1346e66756243d306e2406
2017-08-18 10:41:44 +02:00
Spencer Krum ec9649b4da Use new infra_spec_helper for gem dependencies
Change-Id: Ia50ba84b6bd2b593daac2220cc9b9aa6811ed186
2016-06-21 18:39:12 -07:00
Spencer Krum d8c2cb2b5e Pin google-api-client; sanitize Gemfile
Change-Id: I9cf70ab9eb7bd6d87b0d02399b9136ebddcc49fc
2016-04-14 15:21:14 -07:00
Colleen Murphy c8bf03c398 Add Gemfile and puppet 4 checks
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. This patch also
corrects lint errors caught by the puppet-lint-absolute_classname-check
gem.

Change-Id: Ideaba35b73a03025c3144fceaf5e7836a985ba11
2015-08-07 13:04:07 -07:00