The opendev project has been moving away from puppet and this is one of
the puppet modules that is no longer used. To simplify things for us we
are taking the extra step of retiring this repo.
Change-Id: I46ccab87f063c51dd3236757dbb0567738803fae
The idempotency checks race external changes like updates to
project-config or nodepool. This often causes this job to fail when we
are busy updating other parts of our sytems.
Idempotency is nice but not necessary. Lets remove these checks to make
testing more reliable.
Change-Id: I1092b3a2f4b781465c2148336076677d3c07211e
Add tests for the nodepool launcher and builder. Since by default this
uses the nodepool configuration found in openstack-infra/project-config,
fudge the hostnames so that it can find a real config file.
Depends-On: https://review.openstack.org/577519
Change-Id: I036c1afc0414f846c9112ef5bc5f3abd486f3147
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I1b9ca7f38920a2c901ae16f6302af9b3a1ab36b6
Depends-On: I18ed6cd2f8ee472a66cf580e3e183d14c00e6877
We recently made the epel repository disabled by default, which was
where we were installing puppet from. Since the only reason we weren't
using the beaker functions to install puppet was because of Xenial, we
can just go back to using them for CentOS.
Change-Id: Ib3b2b0b69900313643344908bbacaa9bd03ade93
The puppet-openstackci beaker tests have been failing for all the puppet
modules since they began running on Ubuntu Xenial nodes. This was
because there was no Xenial-specific nodeset file for beaker to run and
it was simply failing upon being unable to find the file.
This patch adds the ubuntu-xenial nodeset. Further, it forgoes the
install_puppet function because it attempts to install puppet 3 from the
puppetlabs apt repo, which does not support Xenial. Because we're
no longer using the install_puppet function, we also need to set default
values for the host object so that we can access things like
host['distmoduledir']. Finally, we add the libffi-dev package since the
keyring pip package requires it to build and it does not seem to be in
our Xenial images.
Change-Id: I8cc44e78116d6a7c8406e6c03756acb63c70834f
In migrating to zuul-launcher, we exposed an issue where the
acceptance testing was replacing the our actually SSH public key in
the gate. Because zuul-launcher does multiple SSH connections to the
node, we end up getting locked out when we attempt to copy over the
logs after the test has been successful.
Change-Id: Ia3e57f645cf11064451570ea0013100666d41bbc
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Use zuul-cloner or a raw modules install to populate puppet module
dependencies during acceptance testing. Most of the scripting is placed
in system-config so that we don't repeat ourselves.
Spec_helper_acceptance.rb is responsible for making sure system-config
is up to date.
Cribbed from I0f63df75fd1a206af7452b239840fd466e6ec080
Change-Id: I81d669513a4f15dbf8879e05401605f94b2dc523
Depends-On: I517954d26409f2fbe96588f40f6f07316d85843d
Co-Authored-By: Monty Taylor <mordred@inaugust.com>
Co-Authored-By: Spencer Krum <nibz@spencerkrum.com>
Co-Authored-By: Colleen Murphy <colleen@gazlene.net>
Updated for suggestions from crinkle. Left spec_helper_acceptance alone
because jeblair's change is the right place to make that modification.
Change-Id: Ic1aa2a0a78ea74661e95399e1e6393af5cf687b0
Clark Boylan