OpenDev is no longer running an openstackid instance and the puppet
module isn't used by the folks running the current instance. We can go
ahead and clean this repo up.
Depends-On: https://review.opendev.org/c/openstack/project-config/+/818170
Change-Id: Ifab5aa7a839d8353aee9acacd5fd2eec525cc924
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I121113f068b8c581bee477c5b77557e6ab155051
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: Ic12edafbb2e33df37c23e3527e961cc71bc67c8c
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-absolute_classname-check gem and arrow
alignment errors now caught by the modern puppet-lint gem.
We disable the puppet-lint-empty_string-check check for now, to be
fixed later, because this module makes heavy use of empty string
defaults and updating this needs to be done with care.
Change-Id: I90e74f25a1aa176d336afc591ac1da9c03c77aa7