summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-08-01Merge "Update Gemfile for Zuulv3"HEADmasterZuul
2018-07-14Fix tests for pip 10Colleen Murphy
On CentOS, the python-ipaddress comes with the python2-pip package which comes installed on the test nodes. Uninstall it (and consequently the distro pip package) so that the new pip can do the right thing. Change-Id: I15fabb2bc2e1645c9045603575dfa52957398a2d Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 21 Jul 2018 14:47:22 +0000 Reviewed-on: https://review.openstack.org/582605 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2018-07-12Update Gemfile for Zuulv3Colleen Murphy
The logic in the Gemfile was relying on Zuulv2 variables to find out whether the spec helper gem was already available on disk, and since Zuulv3 has changed things it was failing to find it and downloading the master version instead. This patch ensures the Gemfile looks for the gem in the right place when running in CI. Change-Id: I8415e5759f05ad9b03196f2d8ca0f09635006efa Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 01 Aug 2018 22:55:08 +0000 Reviewed-on: https://review.openstack.org/582052 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2018-03-26Merge "Depend on helper gem for spec_helper_acceptance"Zuul
2017-09-11Support /usr/local/bin/pip3 as pip3 providerPaul Belanger
It would be possible to only install pip3 from get-pip.py script and not has system packages for pip3. Change-Id: I7b9dabd73d9caef37db1564c4a8358f01f995c2f Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Code-Review+2: Colleen Murphy <colleen@gazlene.net> Workflow+1: Colleen Murphy <colleen@gazlene.net> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Mon, 11 Sep 2017 17:18:49 +0000 Reviewed-on: https://review.openstack.org/502496 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2017-08-25Merge "Ensure curl is installed"Jenkins
2017-08-24Trim the test package list to just shadeClark Boylan
We were installing ~24 packages before. Problem with this is it takes quite a bit of time and is subject to many external failures. Installing just shade should still be a valid test of significant coverage as it is a non trivial python package and we use it in quite a few places. Change-Id: I9cefc83ff280ca00cb434dbe6a1a2357163bc8a6 Notes (review): Code-Review+2: Paul Belanger <pabelanger@redhat.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 24 Aug 2017 23:29:16 +0000 Reviewed-on: https://review.openstack.org/497683 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2017-08-24Ensure curl is installedPaul Belanger
Depends-On: I8b346cbfb908c5d2094c5e46ff008ef735b0e903 Depends-On: Icd0c652ff2f522ce2ea9086965f53e1a03f0d4fd Depends-On: I17c119e81a035916550de44356b9f4badd505c81 Change-Id: Ia8e6bf0a0dd686933cd04a5e678d1f88ebdd8245 Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Fri, 25 Aug 2017 01:12:18 +0000 Reviewed-on: https://review.openstack.org/497484 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2017-08-18Depend on helper gem for spec_helper_acceptanceColleen Murphy
Instead of keeping a local copy of spec_helper_acceptance.rb and requiring updates to all modules for any change, we can move it into the common helper gem and require it from there. This will make it easier to create and review changes that affect all puppet modules. Also change the Gemfile to look for the gem in the local workspace if running in a zuul environment. Change-Id: I5c18fc44e41e14868c4dcc38bbd7ad09a960b5e8 Notes (review): Code-Review+2: Paul Belanger <pabelanger@redhat.com> Workflow+1: Paul Belanger <pabelanger@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 26 Mar 2018 21:59:46 +0000 Reviewed-on: https://review.openstack.org/495629 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2017-06-11Fix beaker on xenialColleen Murphy
Add a xenial nodeset and update the spec helper to install puppet 3 from the Ubuntu repos instead of from puppetlabs. Change-Id: I2ba699d58fe29854d078199c95dd3ea061086793 Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Ian Wienand <iwienand@redhat.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Tue, 13 Jun 2017 21:53:53 +0000 Reviewed-on: https://review.openstack.org/473101 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2017-06-01Switch incorrect symlink orderPaul Belanger
All this did was symlnk pip2 to pip, which became installed by python3 on our previous run. We need to properly revert this on our production systems now. Change-Id: Ie27c4476ecea9d0a29f40400bbc3bdbe704905a6 Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: Colleen Murphy <colleen@gazlene.net> Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Workflow+1: Jeremy Stanley <fungi@yuggoth.org> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 01 Jun 2017 14:14:27 +0000 Reviewed-on: https://review.openstack.org/469851 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2017-05-31Add pip3 supportPaul Belanger
We are wanting to start running python3 applications in production, as a results we need to ensure that pip3 is created. Because get-pip.py will override existing pip executables, it will be possible for an existing server to have is version change to python3. As a result, symlink specifically to pip2 to ensure we have defaulted properly to python3. Drop Babel from acceptance testing, this appears to be a failure that needs to be looked at in the future. Change-Id: I8f78dfc62cd3745e900eec573e80236137ac5c78 Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Code-Review+2: Paul Belanger <pabelanger@redhat.com> Workflow+1: Paul Belanger <pabelanger@redhat.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 31 May 2017 20:03:56 +0000 Reviewed-on: https://review.openstack.org/469559 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2017-02-24Add support for Suse familyDirk Mueller
Change-Id: I92ac35151364c2390eddf2a8c71985049d3814c3 Notes (review): Code-Review+1: Armando Migliaccio <armamig@gmail.com> Code-Review+1: Markos Chandras (hwoarang) <mchandras@suse.de> Code-Review+2: Colleen Murphy <colleen@gazlene.net> Code-Review+2: Paul Belanger <pabelanger@redhat.com> Workflow+1: Paul Belanger <pabelanger@redhat.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Sat, 08 Apr 2017 23:50:53 +0000 Reviewed-on: https://review.openstack.org/438881 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2016-06-28Fix openstack_pip provider to support old pipAlexander Evseev
Do not split string by hyphen and change regex to match both formats - new (with hyphen), and old one like 'pep8 (Current: 1.5.7 Latest: 1.7.0)' Change-Id: I1eeda1b35ff35dfe8b8b0c6e948616a55f33df25 Notes (review): Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Code-Review+2: yolanda.robla <yroblamo@redhat.com> Workflow+1: yolanda.robla <yroblamo@redhat.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 30 Jun 2016 08:15:06 +0000 Reviewed-on: https://review.openstack.org/332725 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2016-06-22Fix search of latest package versionAlexander Evseev
In case, when there is more than one obsoleted package, incorrect package version is chosen. For example: /usr/local/bin/pip --version pip 8.1.2 from /usr/local/lib/python2.7/dist-packages (python 2.7) /usr/local/bin/pip list --obsolete alabaster (0.7.6) - Latest: 0.7.8 [wheel] Babel (1.3) - Latest: 2.3.4 [wheel] ... tox (1.6.0) - Latest: 2.3.1 [wheel] ... Puppet output: Debug: Executing '/usr/local/bin/pip list --outdated' Debug: /Stage[main]/Jenkins::Slave/Package[tox]/ensure: tox "1.6.0" is installed, latest is "0.7.8" Debug: Executing '/usr/local/bin/pip install -q --upgrade tox' Notice: /Stage[main]/Jenkins::Slave/Package[tox]/ensure: ensure changed '1.6.0' to '0.7.8' Change-Id: Ia46c10ef4220be47e34c08cfd2be69e8c349f73d Notes (review): Code-Review+2: Spencer Krum <nibz@spencerkrum.com> Code-Review+1: K Jonathan Harker <code@gentlydownthe.net> Code-Review+2: yolanda.robla <yroblamo@redhat.com> Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Workflow+1: Jeremy Stanley <fungi@yuggoth.org> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Tue, 28 Jun 2016 17:01:19 +0000 Reviewed-on: https://review.openstack.org/332793 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2016-06-21Use new infra_spec_helper for gem dependenciesSpencer Krum
Change-Id: I49b48e8282aed3c3c8c3596d7f8b7c8ff2ce7f41 Notes (review): Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Workflow+1: Jeremy Stanley <fungi@yuggoth.org> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 22 Jun 2016 02:27:06 +0000 Reviewed-on: https://review.openstack.org/332557 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2016-06-16Declare features in openstack_pip providerSpencer Krum
Puppet providers can express what features they can provide using the has_features variable. The declaration of features isn't inherited, so we need to declare the features that we inherited from the core pip provider. Change-Id: I2f4c6254bb7f45649658d6a6b296ea1270ce6364 Notes (review): Code-Review+2: Colleen Murphy <colleen@gazlene.net> Workflow+1: Colleen Murphy <colleen@gazlene.net> Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+1: Philip Marc Schwartz <pschwar@linux.vnet.ibm.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 16 Jun 2016 18:02:08 +0000 Reviewed-on: https://review.openstack.org/330657 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2016-04-14Pin google-api-client; sanitize GemfileSpencer Krum
Change-Id: If829487c8c4d93235a1ade1afeed1b1ba2fe345d Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Fri, 15 Apr 2016 09:34:30 +0000 Reviewed-on: https://review.openstack.org/306146 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2016-04-08Add new pip provider to use pypi mirrorsColleen Murphy
The upstream pip provider hard-codes pypi.python.org as the index to search when determining the latest available release of a package. This means puppet won't use our mirrors on the second run of a pip package resource using ensure => latest. This patch adds a new provider that inherits from the upstream one and overrides the latest() method to just use `pip list --outdated` to see what the latest version is. This could potentially be proposed upstream in the future depending on what versions of pip support 'list --outdated' and what systems require support. To use this, package resources currently using the 'pip' provider will have to switch to the 'openstack_pip' provider. Change-Id: I6c24c8f99fb3f879a30d21f38d1ad883f96f7937 Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Workflow+1: Jeremy Stanley <fungi@yuggoth.org> Code-Review+2: Spencer Krum <nibz@spencerkrum.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Tue, 12 Apr 2016 02:41:39 +0000 Reviewed-on: https://review.openstack.org/302396 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2016-04-06Fix pip executable path for RHColleen Murphy
get-pip.py installs pip to /bin/pip on centos 7. Without this fix, the download-pip exec will keep trying to install pip whether or not it is already installed on our base images or by puppet. Change-Id: Ic5bcce59148aacedc61315e616317fc73c2c161c Notes (review): Code-Review+2: yolanda.robla <yolanda.robla-mota@hpe.com> Code-Review+1: Ricardo Carrillo Cruz <ricardo.carrillo.cruz@gmail.com> Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Workflow+1: Jeremy Stanley <fungi@yuggoth.org> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Tue, 12 Apr 2016 02:41:08 +0000 Reviewed-on: https://review.openstack.org/302431 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2016-03-21Order of the class parameters is refactoredAndrey Nikitin
Order and intendation of those parameters are changed to follow Puppet Style Guide recommendation [0]. Moreover, it will allow to an user to find much faster a variable in a list of variables. [0]. https://docs.puppetlabs.com/guides/style_guide.html Change-Id: I1c319006878007d9d93a201a40c70843fa1bcf21 Notes (review): Code-Review+2: yolanda.robla <yolanda.robla-mota@hpe.com> Code-Review+1: Ricardo Carrillo Cruz <ricardo.carrillo.cruz@gmail.com> Code-Review+2: Spencer Krum <nibz@spencerkrum.com> Workflow+1: Spencer Krum <nibz@spencerkrum.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 30 Mar 2016 17:38:24 +0000 Reviewed-on: https://review.openstack.org/295340 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2015-10-09Merge "Allow to send optional values to configuration"Jenkins
2015-09-24Merge "Fix the puppet-pip module to install pip"Jenkins
2015-09-02Fix the puppet-pip module to install pipRicardo Carrillo Cruz
The class pip does not install pip, as one would expect. This fixes it. Change-Id: I926cbfc1f65805c29a72597eede8c47228bdee30 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Jenkins Code-Review+2: yolanda.robla <info@ysoft.biz> Code-Review+1: Colleen Murphy <colleen@gazlene.net> Code-Review+1: Bruno Tavares <btavare@thoughtworks.com> Submitted-by: Jenkins Submitted-at: Thu, 24 Sep 2015 19:58:31 +0000 Reviewed-on: https://review.openstack.org/211016 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2015-08-19Fix target path for regular git clone during testsSpencer Krum
Use same target directory for zuul-cloner and the regular git command. Change-Id: Ic0079d1de6549c8b21974fc18cc6e8858e22aa44 Co-Authored-By: Fabien Boucher <fabien.boucher@enovance.com> Notes (review): Verified+2: Jenkins Code-Review+2: yolanda.robla <info@ysoft.biz> Workflow+1: yolanda.robla <info@ysoft.biz> Submitted-by: Jenkins Submitted-at: Mon, 24 Aug 2015 11:19:27 +0000 Reviewed-on: https://review.openstack.org/214868 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2015-08-10Merge "Fix warning on puppet-pip about trusted-hosts"Jenkins
2015-08-06Add Gemfile and puppet 4 checksPaul Belanger
In anticipation of puppet 4, start trying to deal with puppet 4 things that can be helpfully predicted by puppet lint plugins. Change-Id: I498052d2db57e571f0f91cd2c2e43e39c693331f Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Jenkins Code-Review+2: yolanda.robla <info@ysoft.biz> Code-Review+1: Colleen Murphy <colleen@gazlene.net> Submitted-by: Jenkins Submitted-at: Sun, 09 Aug 2015 03:13:53 +0000 Reviewed-on: https://review.openstack.org/210070 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2015-08-03Allow to send optional values to configurationYolanda Robla
Under certain situations, is useful to send some extra configuration to pip.conf, such as the retries, timeout, etc... This change allows to pass extra values as optional settings to the template. Change-Id: Ibcf431a17717fb7f8b8f501603f035fd9456def4 Notes (review): Verified+2: Jenkins Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Workflow+1: Jeremy Stanley <fungi@yuggoth.org> Code-Review+1: K Jonathan Harker <code@gentlydownthe.net> Code-Review+2: Spencer Krum <nibz@spencerkrum.com> Code-Review+1: Colleen Murphy <colleen@gazlene.net> Code-Review+1: Ramy Asselin <ramy.asselin@hpe.com> Code-Review+1: Glauco Oliveira <gvinici@thoughtworks.com> Submitted-by: Jenkins Submitted-at: Fri, 09 Oct 2015 13:39:16 +0000 Reviewed-on: https://review.openstack.org/201083 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2015-08-03Fix warning on puppet-pip about trusted-hostsYolanda Robla
Change-Id: Ieef9d04d9f94746b76aaca0d218a4e220f79fbbf Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Verified+2: Jenkins Code-Review+1: Ricardo Carrillo Cruz <ricardo.carrillo.cruz@gmail.com> Code-Review+1: Paul Belanger <pabelanger@redhat.com> Code-Review+1: K Jonathan Harker <code@gentlydownthe.net> Code-Review+1: Colleen Murphy <colleen@gazlene.net> Submitted-by: Jenkins Submitted-at: Mon, 10 Aug 2015 15:13:21 +0000 Reviewed-on: https://review.openstack.org/208446 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2015-07-28Boilerplate beaker-rspec filesSpencer Krum
Change-Id: Ibf0ab54f5240968e82b22626a2fb4a444a87da31 Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Jenkins Code-Review+2: yolanda.robla <info@ysoft.biz> Code-Review+1: Clint Adams <clint@gcfm.net> Submitted-by: Jenkins Submitted-at: Thu, 30 Jul 2015 00:27:14 +0000 Reviewed-on: https://review.openstack.org/206405 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2015-05-14Replace ci.o.o links with docs.o.o/infraJeremy Stanley
The http://ci.openstack.org/ documentation site has been deprecated, replaced by redirects to corresponding paths within http://docs.openstack.org/infra/ where other Project Infrastructure documentation already resides. Change-Id: I8c2af9695ee29c04e3193c5b1e903fe435b3dea4 Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 14 May 2015 23:22:34 +0000 Reviewed-on: https://review.openstack.org/183281 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2015-04-20Rename openstackci to openstackinfraRamy Asselin
Change-Id: If3f3bb46b358e0302ca8d1a0806893794640d3d5 Notes (review): Verified+2: Jenkins Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Workflow+1: Jeremy Stanley <fungi@yuggoth.org> Submitted-by: Jenkins Submitted-at: Tue, 21 Apr 2015 18:13:48 +0000 Reviewed-on: https://review.openstack.org/175665 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2015-04-10Add the ability to set pip.conf and configure itYolanda Robla
Create an initial pip.conf file and allow passing several settings such as index url and trusted hosts. Change-Id: I78962555c9a9ec1a96ce19810a463a5d619b04f9 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Verified+2: Jenkins Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Code-Review+1: Spencer Krum <nibz@spencerkrum.com> Submitted-by: Jenkins Submitted-at: Mon, 20 Apr 2015 19:53:29 +0000 Reviewed-on: https://review.openstack.org/168309 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2015-01-29Add puppet module files for pipRamy Asselin
Change-Id: I2d282f5fa26b150853f480bf3531af8e75bc2b51 Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Verified+2: Jenkins Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Submitted-by: Jenkins Submitted-at: Thu, 29 Jan 2015 23:58:40 +0000 Reviewed-on: https://review.openstack.org/151462 Project: openstack-infra/puppet-pip Branch: refs/heads/master
2013-12-18Install pip using get-pip in launch nodeMonty Taylor
packaged pip vs. upstream pip gets the systems very broken. Make launch-node use get-pip to install pip as per: http://www.pip-installer.org/en/latest/installing.html Change-Id: Ice28b47d766c04b42462a7297911dc1a1abe5a77
2013-08-06No longer link pip to pip-python on Red HatJeremy Stanley
* modules/pip/manifests/init.pp: Remove the symlink workaround for older python-pip EPEL packages since current versions now provide /usr/bin/pip directly instead of /usr/bin/pip-python. The latter has been switched to a symlink itself, so without this change in Puppet we get circular symlinks and no executable. Change-Id: If09a9c2a511dcc9ae845833543e304f1459fdeb2
2013-07-12Make pip3_cmd a class method.Jeremy Stanley
* modules/pip/lib/puppet/provider/package/pip3.rb(pip3_cmd): The instances class method was attempting to call the pip3_cmd instance method, which does not work. Instead define a self.pip3_cmd method it can call and then delegate the pip3_cmd instance method to that. Also corrects an error message typo in passing. Change-Id: I8a7b7ce353ac4293c2d7b82999402fa47dde6051 Reviewed-on: https://review.openstack.org/35708 Reviewed-by: James E. Blair <corvus@inaugust.com> Approved: Clark Boylan <clark.boylan@gmail.com> Reviewed-by: Clark Boylan <clark.boylan@gmail.com> Tested-by: Jenkins
2013-06-25Don't symlink pip on Fedora.Jeremy Stanley
* modules/pip/manifests/init.pp: Fedora installs /usr/bin/pip and thus doesn't need a symlink there like CentOS and RHEL do. Change-Id: I2da3d5ed11db94da3ee2c3c7cae96c76e124dbd5 Reviewed-on: https://review.openstack.org/34081 Reviewed-by: Clark Boylan <clark.boylan@gmail.com> Approved: James E. Blair <corvus@inaugust.com> Reviewed-by: James E. Blair <corvus@inaugust.com> Tested-by: Jenkins
2013-06-24Add pip::python3 module and pip3 provider.Dan Prince
Adds python3 support to our pip package. Also adds a custom version of the pip package provider which can be used when installing things w/ python3-pip is explicitly required. For example: package { 'tox', provider => pip3, require => Class[pip::python3], } Change-Id: I1b563c8f7e647dad3a134ef1f0ec5b45b63f8b71 Reviewed-on: https://review.openstack.org/32451 Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Reviewed-by: James E. Blair <corvus@inaugust.com> Approved: Clark Boylan <clark.boylan@gmail.com> Reviewed-by: Clark Boylan <clark.boylan@gmail.com> Tested-by: Jenkins
2013-04-25The facter osfamily of Ubuntu is Debian.Jeremy Stanley
Clean up facter osfamily matches to just use Debian, not Ubuntu. This is manually tested and confirmed to at least be the case on Oneiric, Precise and Quantal. Change-Id: I27b184ac419910f9c3271c3b4e57886333282a5f Reviewed-on: https://review.openstack.org/27399 Reviewed-by: Spencer Krum <krum.spencer@gmail.com> Reviewed-by: Clark Boylan <clark.boylan@gmail.com> Reviewed-by: James E. Blair <corvus@inaugust.com> Approved: Jeremy Stanley <fungi@yuggoth.org> Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Tested-by: Jenkins
2013-04-25Jenkins slave puppetry for CentOS.Jeremy Stanley
The install scripts now look for CentOS in release files. Also some instances of facter's operatingsystem are switched to osfamily and capitalization of RedHat is normalized to match what facter uses. Change-Id: I3bbca5481d0d5e6de9e62bfd6e2b0a85264ed6ed Reviewed-on: https://review.openstack.org/27398 Reviewed-by: Clark Boylan <clark.boylan@gmail.com> Reviewed-by: James E. Blair <corvus@inaugust.com> Approved: Jeremy Stanley <fungi@yuggoth.org> Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Tested-by: Jenkins
2013-01-17Update pip module to support Red Hat distros.Dan Prince
Adds a new pip::params module where we set parameters based on the operating system. Updates the pip::init module so that it makes use of distro specific parameters. Also, includes a change to pip::init so that a soft link is created for /usr/bin/pip (pointing to /usr/bin/pip-python). This is required in order for the Puppet pip provider to work on Red Hat distributions. Seems like we should push a fix into Puppet for this as well but having this live here for now seems reasonable. Change-Id: Ifee6bc42fabcf65ee1241ffac38f3bead7335be1 Reviewed-on: https://review.openstack.org/18904 Reviewed-by: Monty Taylor <mordred@inaugust.com> Reviewed-by: Clark Boylan <clark.boylan@gmail.com> Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Reviewed-by: James E. Blair <corvus@inaugust.com> Approved: James E. Blair <corvus@inaugust.com> Tested-by: Jenkins
2012-11-30Additional puppet-lint formattingPaul Belanger
Change-Id: I6e5fa77a301eec30cff8e16bad33a91bfd95b13f Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com> Reviewed-on: https://review.openstack.org/17176 Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Reviewed-by: James E. Blair <corvus@inaugust.com> Approved: Jeremy Stanley <fungi@yuggoth.org> Tested-by: Jenkins
2012-07-23Move python-pip include to a class.Monty Taylor
You can't have two different classes install the same package (FAIL) But you can have two different classes include the same class, so by encapsulating the "install pip" code into a module, we can safely consume it across multiple modules. Sometimes I really hate puppet. Change-Id: I3467c52b6887298c1b4d01a29873c63edf0adfd3