The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: Iaf82b5b89b4b01b811189f7a4c451ddfca8a80ad
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I2fd13c3aa1b5bb6775c1963f769e6be7e0b8dafb
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins.
This patch also corrects lint errors caught by the
puppet-lint-empty_string-check plugin by changing the default value of
the $base parameter to be undef instead of empty string, which will be
evaluated the same when interpolated in a string, and by making the
$url parameter required.
Change-Id: Ic1146cbd44b589c5dfca10deb410301ef4d46528
Colleen Murphy