This checks if the $::project_config_ref fact is defined before
accessing it. Puppet 4 seems to care about his more than puppet 3 so we
are only just notcing this now.
Note that this fix relies on puppet boolean operator 'and' short
circuiting which I'm not entirely sure if it does yet.
Change-Id: I2b89ac146609f9c3b22c05814b85c646f74b393a
What we really want to the fqdn, since that is how we store the
filename in project-config.
Change-Id: Ie1337ce233bc7f270acfcdab7632326d412b05e5
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Switch to use hostname to find the nodepoolv3 configuration file from
project-config.
Change-Id: I7c8d37c747083cc34c5ed9632be002ed0c6f4b9b
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This creates a new entry point in project-config for zuul-executor
site-variable.yaml file.
Change-Id: I1e1d6ef7476586131334e0e34772499b808c6da9
Depends-On: I9f495e1568efcbcb74260579ca26ef040eecd748
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This is part of our zuulv3 effort, we need to care two nodepool.yaml
files for a while.
Change-Id: Ic04d3f625e4f0b05317ea6348b6d02e730bd61b3
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Order and intendation of those parameters are changed
to follow Puppet Style Guide recommendation [0].
Moreover, it will allow to an user to find much faster
a variable in a list of variables.
[0]. https://docs.puppetlabs.com/guides/style_guide.html
Change-Id: Ia1bccf2e4b52b83b679c1a7dff202bcc9b37c989
It should have been done when nodepool.yaml moved into proejct-config
in I473a1b78acdb035eb379394a7ed5f771434dc942.
Once added, openstackci::nodepool can use it instead of hard coding
the location.
Needed-By: I0cb03ba0256fac5d789941cc16f8f8ade75a3c33
Change-Id: I9aeac79b7039c1e3c2db93b52587ec948a7fbf91
Having to create a custom fact to set project_config ref could be an
overkill for some use cases, e.g. for setting up a third-party CI.
Change-Id: I9772e10a3a56f900e56d425fe7bbfd2261360c1a
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins.
This patch also corrects lint errors caught by the
puppet-lint-empty_string-check plugin by changing the default value of
the $base parameter to be undef instead of empty string, which will be
evaluated the same when interpolated in a string, and by making the
$url parameter required.
Change-Id: Ic1146cbd44b589c5dfca10deb410301ef4d46528
It's useful to be able to add data files on our workers as a common
reference, much in the same way job scripts are provided. This will
be used to keep a local copy of the bindep fallback package list so
that it doesn't require directly cloning the project-config repo
during job run-time.
Change-Id: I30a8be9167cc5c52faae59a35a284b3f37b93f44
We don't always want to use just 'master' since that may result in races
when running puppet across many nodes while project_config is changing.
Allow for a way to specify the ref we want via facter with a fallback to
master if the fact does not exist.
Change-Id: If1c17e55c7f1b15d28748761c3ee99af88fada40
Instead of publishing a static file, we will generate the
specs.openstack.org root page from a jenkins job.
Depends-On: I828d65f10fb7608b59e3561cedc9553d4d96ee75
Change-Id: Ib2d2bc212591aa54c51ca3669baf8168fd99876f
Start using the project-config repo for Zuul. Stop managing
/etc/zuul/layout in the zuul module itself in favor of the
project_config module.
Change-Id: I46ddb22c53783c0cffa665959f708b0568abd25f