The opendev project has been moving away from puppet and this is one of
the puppet modules that is no longer used. To simplify things for us we
are taking the extra step of retiring this repo.
Change-Id: I6a1d385c8dc3a457af2ef3b8a376470fecc754d4
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: If01c1b3eb22bc3c751c6a13eafea369a7cef4e49
Required parameters must be listed first now, so this patch
brings required parameters to the top.
Also use infra_spec_helper for gem dependencies like other puppet
projects.
Change-Id: Ib9808fda496cada13d0b2b65e6f155022ebafdf9
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix errors
caught by the puppet-lint-absolute_classname-check gem.
Change-Id: I34bb706397bff9c5d8239c7ae7f5402c1ca9b118