The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I086c465732003c674b6df421a26bbaad1c5748bf
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: If5989b7a19ae2f41d8873ad94b3b0cec532820cc
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-empty_string-check gem:
- releasestatus base class: replacing empty string defaults with undef
- releasestatus::site class: replacing empty string defaults with
reasonable default values inspired by system-config's usage
Change-Id: I7ce45ac86da0d7dcdb90deb292973c8cdde0421a
Andreas Jaeger