Order and intendation of those parameters are changed
to follow Puppet Style Guide recommendation [0].
Moreover, it will allow to an user to find much faster
a variable in a list of variables.
[0]. https://docs.puppetlabs.com/guides/style_guide.html
Change-Id: I54071ce317178febf2e28e11858a247ba2f070fe
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-empty_string-check gem:
- releasestatus base class: replacing empty string defaults with undef
- releasestatus::site class: replacing empty string defaults with
reasonable default values inspired by system-config's usage
Change-Id: I7ce45ac86da0d7dcdb90deb292973c8cdde0421a
A run on a new server produces:
err: /Stage[main]/Openstack_project::Static/Releasestatus::Site[releasestatus]/File[/srv/static/release]: Failed to generate additional resources using 'eval_generate: undefined method `relative_path' for nil:NilClass
err: /Stage[main]/Openstack_project::Static/Releasestatus::Site[releasestatus]/File[/srv/static/release]: Could not evaluate: Could not retrieve information from environment production source(s) file:/var/lib/releasestatus/releasestatus/static at /opt/config/production/modules/releasestatus/manifests/site.pp:36
Change-Id: Iff895f56cf676f13f9b55f564d907c285dd49f6e
We have a cgit server now, which means we should replace
all references to github with references to git.openstack.org.
Change-Id: I68ad1ce514fb4326c7d9940b5a84999af5b58562
At random, some hosts within Rackspace refuse to send IPv6 packets
with DSCP marker 0x10 (lowdelay). This is the default behavior of
recent OpenSSH servers and clients, and results in SSH sessions
hanging on these hosts. When static.openstack.org was rebuilt a few
months ago, we did not immediately realize it suffered from this
problem as Rackspace thought they'd fixed the issue previously. We
have an open trouble ticket with them for the past several months to
get it addressed properly, but have no resolution yet. In the
meantime, we have this lovely workaround...
* modules/releasestatus/files/ssh_config: New SSH config file forces
IPv4 when connecting to review.openstack.org from the releasestatus
account.
* modules/releasestatus/manifests/init.pp: Installs the new SSH
config file.
Change-Id: I2968fc00750e3a5a23c08a3007318fd2e336b251
Reviewed-on: https://review.openstack.org/30944
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Elizabeth Krumbach Joseph <lyz@princessleia.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Add an SSH keypair for releasestatus so that it can connect to
review.openstack.org to grab review data. Also add review.o.o
public key to known_hosts.
The data in hiera was already added.
Change-Id: I193dfad5b229a0c193ce35d5a8917b0b3b86c117
Reviewed-on: https://review.openstack.org/30881
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
Now that the conflicting directory has been cleared out.
Change-Id: I7fb86258a431c4ee8ecf94eab0c6e95ceeb67b03
Reviewed-on: https://review.openstack.org/29826
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
The directory conflicts with the vcsrepo resource.
See next commit which adds the vcsrepo back.
Change-Id: I8292c9ad91951364f34517a0f582bdb611f6c2db
Reviewed-on: https://review.openstack.org/29825
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
Deploy releasestatus under static.openstack.org, as a first step
towards getting rid of the old-wiki.o.o redirection.
The static.o.o releasestatus will be accessible for testing at:
http://status.openstack.org/release.new
If everything behaves properly we'll get rid of the redirect and
make it accessible under http://status.openstack.org/release in a
future commit.
Prerequisite is to complete the git repo move under openstack-infra.
Change-Id: I3d71dc897c16a9ab2d85b6c304a6c8b800ba939e
Reviewed-on: https://review.openstack.org/28966
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Andreas Jaeger